kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-04-03 18:49:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor MasterElement::isFull for clarity

Browse Source
This commit is contained in:
Kellermorph
2026-03-31 17:51:32 +02:00
committed by GitHub
parent 89a4aaac28
commit 246dd0a42f
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
sources/qetgraphicsitem/masterelement.cpp
View File

@@ -181,7 +181,7 @@ void MasterElement::aboutDeleteXref()
delete m_Xref_item; delete m_Xref_item;
m_Xref_item = nullptr; m_Xref_item = nullptr;
return; return;
} }
} }
/** /**
@@ -190,20 +190,20 @@ void MasterElement::aboutDeleteXref()
*/ */
bool MasterElement::isFull() const bool MasterElement::isFull() const
{ {
// Set default value to -1 (unlimited slaves) // Set default value to -1 (unlimited slaves)
int max_slaves = -1; int max_slaves = -1;
QVariant max_slaves_variant = kindInformations().value("max_slaves"); QVariant max_slaves_variant = kindInformations().value("max_slaves");
// Overwrite default if a valid limit is defined in the element's XML // Overwrite default if a valid limit is defined in the element's XML
if (max_slaves_variant.isValid() && !max_slaves_variant.toString().isEmpty()) { if (max_slaves_variant.isValid() && !max_slaves_variant.toString().isEmpty()) {
max_slaves = max_slaves_variant.toInt(); max_slaves = max_slaves_variant.toInt();
} }
// If no limit is set (-1), the master is never full // If no limit is set (-1), the master is never full
if (max_slaves == -1) { if (max_slaves == -1) {
return false; return false;
} }
// Return true if current connected elements reached or exceeded the limit // Return true if current connected elements reached or exceeded the limit
return connected_elements.size() >= max_slaves; return connected_elements.size() >= max_slaves;
} }