Revert "Try Clazy fix-its"

Segfault on old Qt versions!
This reverts commit dba7caed30.
This commit is contained in:
Laurent Trinques
2025-02-14 16:17:58 +01:00
parent dba7caed30
commit 43f0107eb1
88 changed files with 409 additions and 512 deletions

View File

@@ -130,9 +130,9 @@ void ElementQueryWidget::setQuery(const QString &query)
//Get the select -> the item in the right list
QStringList split = select.split(",");
for (const auto& str : std::as_const(split))
for (auto str : split)
{
for (auto item : std::as_const(m_items_list))
for (auto item : m_items_list)
{
if (item->data(Qt::UserRole).toString() == str) {
ui->m_var_list->takeItem(ui->m_var_list->row(item));
@@ -209,8 +209,7 @@ void ElementQueryWidget::setQuery(const QString &query)
//Filter for selected data
QStringList strl;
for (auto item : std::as_const(m_items_list))
{
for (auto item : m_items_list) {
strl.append(item->data(Qt::UserRole).toString());
}
@@ -237,7 +236,7 @@ void ElementQueryWidget::setQuery(const QString &query)
QRegularExpressionMatch rxm;
for (const auto& str : split_where)
for (auto str : split_where)
{
rxm = rx_is_not_null.match(str);
if (rxm.hasMatch()) {
@@ -298,8 +297,7 @@ QString ElementQueryWidget::queryStr() const
QString column;
bool first = true;
for (auto key : std::as_const(keys))
{
for (auto key: keys) {
if (first) {
first = false;
} else {
@@ -456,7 +454,7 @@ QStringList ElementQueryWidget::selectedKeys() const
*/
void ElementQueryWidget::setUpItems()
{
for (const QString& key : QETInformation::elementInfoKeys())
for(QString key : QETInformation::elementInfoKeys())
{
if (key == "formula")
continue;
@@ -466,7 +464,8 @@ void ElementQueryWidget::setUpItems()
m_items_list << item;
}
for (const auto& key : m_export_info.keys())
for (auto key : m_export_info.keys())
{
auto item = new QListWidgetItem(m_export_info.value(key), ui->m_var_list);
item->setData(Qt::UserRole, key);