kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-09-28 04:54:13 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #1045: crash on selecting an element with the online-installer Qt

Browse Source 
Since #983, projectDataBase::newQuery() checked a query with
sqlite3_prepare_v2() and sqlite3_stmt_readonly() on the handle of the
QSQLITE driver. Those calls go to the libsqlite3 QElectroTech links. The
QSQLITE plugin of the Qt online installer does not use that library: it
carries its own copy of SQLite, so the handle belongs to another library
and the call crashes. #1021 then put newQuery() on every element
selection, which is where #1045 hits it.

The check now runs the query with PRAGMA query_only set, through the
driver. SQLite refuses a write itself, before touching a row, so the CTE
prefix #983 closed ("WITH x AS (SELECT 1) DELETE FROM element") stays
closed. A refused or failed query comes back empty, because several
callers call exec() again on what newQuery() returns, after query_only
is off.

QElectroTech no longer calls the SQLite C API anywhere.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ispyisail
2026-09-26 19:20:47 +12:00
parent 923367d2a8
commit 45aec7735b
6 changed files with 197 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sources/dataBase/sqlreadonly.h
+11 -11
View File
@@ -18,26 +18,26 @@
#ifndef SQLREADONLY_H
#define SQLREADONLY_H
#include <QSqlDatabase>
#include <QSqlQuery>
#include <QString>
struct sqlite3;
/**
Deciding whether a piece of SQL only reads.
Running a piece of SQL only if it reads.
Deliberately its own translation unit, depending on nothing but QString
and SQLite: it is the enforcement point for every query QElectroTech
runs against a project database, including queries that arrive from
outside the application (a .qet file's saved report/table query), so it
is worth being able to test it in isolation -- see
Deliberately its own translation unit, depending on nothing but Qt SQL:
it is the enforcement point for every query QElectroTech runs against a
project database, including queries that arrive from outside the
application (a .qet file's saved report/table query), so it is worth
being able to test it in isolation -- see
tests/qttest/tst_sqlreadonly.cpp, which links this file and nothing
else of QElectroTech.
*/
namespace QETSql {
bool isSingleReadOnlyStatement(sqlite3 *handle,
const QString &query,
QString *error = nullptr);
QSqlQuery execReadOnly(const QSqlDatabase &db,
const QString &query,
QString *error = nullptr);
}
#endif // SQLREADONLY_H