kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-10-07 12:14:14 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix repeatable PDF changing with the output folder (#1178)

Browse Source 
Rewriting the links copied the old trailer up to %%EOF, so the old
startxref stayed in the file before the new one. Its offset is the size
the file had before the rewrite, and the links carry the output path,
so the same project exported to two folders gave different bytes, and
a different document id. Both rewrites now copy the trailer dictionary
only, through one helper; the print window's rewrite no longer leaves a
stray %%EOF either.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ispyisail
2026-10-05 21:43:28 +13:00
parent a5cd68ced5
commit 527b0f3b2d
2 changed files with 42 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/qttest/tst_pdfreproducible.cpp
+24 -2
View File
@@ -22,12 +22,17 @@ class tst_pdfreproducible : public QObject
QTemporaryDir m_dir;
int m_run = 0;
QByteArray exportPdf(const QString &project, const QByteArray &epoch)
QByteArray exportPdf(const QString &project, const QByteArray &epoch,
const QString &folder = QString())
{
const int run = m_run++;
const QString home = m_dir.filePath(QStringLiteral("home%1").arg(run));
const QString tmp = m_dir.filePath(QStringLiteral("tmp%1").arg(run));
const QString out = m_dir.filePath(QStringLiteral("out%1.pdf").arg(run));
const QString out = folder.isEmpty()
? m_dir.filePath(QStringLiteral("out%1.pdf").arg(run))
: m_dir.filePath(folder + QStringLiteral("/same.pdf"));
if (!folder.isEmpty())
QDir().mkpath(m_dir.filePath(folder));
QDir().mkpath(home);
QDir().mkpath(tmp);
QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
@@ -145,6 +150,23 @@ private slots:
"the same drawing with new uuids gives a different PDF");
}
void sameBytesInAnyFolder()
{
// #1178: the links carry the output path, and rewriting them left
// the old startxref in the file, with the size the file had before.
const QString project =
QStringLiteral(QET_EXAMPLES_DIR) + QStringLiteral("/iso_sfc_example.qet");
QVERIFY2(QFile::exists(project), "examples/iso_sfc_example.qet not found");
const QByteArray first = exportPdf(project, "1700000000", QStringLiteral("p"));
QVERIFY(!first.isEmpty());
QVERIFY(first.contains("/GoTo"));
QCOMPARE(first.count("startxref"), 1);
QVERIFY2(xrefMatches(first), "the xref table does not match the file");
QVERIFY2(exportPdf(project, "1700000000", QStringLiteral("longer-folder-name")) == first,
"the same project gives a different PDF in another folder");
}
void nowWithoutTheVariable()
{
const QString project =