kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2025-12-18 05:00:33 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

do not set parts again when they are set already

Browse Source
This commit is contained in:
Martin Marmsoler
2020-06-01 20:46:34 +02:00
committed by Laurent Trinques
parent d7b5ceece1
commit 83f4a7c6ba
1 changed files with 26 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
sources/editor/qetelementeditor.cpp
View File

@@ -640,22 +640,40 @@ void QETElementEditor::slot_updateInformations()
style_editable = StyleEditor::isStyleEditable(cep_list); style_editable = StyleEditor::isStyleEditable(cep_list);
if (same_xml_name) { if (same_xml_name) {
//The current editor already edit the selected part
// Expensive for a list of elements
// if (QWidget *widget = m_tools_dock_stack->widget(1))
// if (ElementItemEditor *editor = dynamic_cast<ElementItemEditor *>(widget))
// if(editor->currentPart() == cep_list.first())
// return;
if (selection_xml_name == "terminal" || if (selection_xml_name == "terminal" ||
selection_xml_name == "text" || selection_xml_name == "text" ||
selection_xml_name == "dynamic_text") { selection_xml_name == "dynamic_text") {
clearToolsDock(); clearToolsDock();
//We add the editor widget //We add the editor widget
ElementItemEditor *editor = static_cast<ElementItemEditor*>(m_editors[selection_xml_name]); ElementItemEditor *editor = static_cast<ElementItemEditor*>(m_editors[selection_xml_name]);
// TODO: Check if it takes longer than setting the parts again to the editor.
bool equal = true;
QList<CustomElementPart*> parts = editor->currentParts();
if (parts.length() == cep_list.length()) {
for (auto cep: cep_list) {
bool part_found = false;
for (auto part: parts) {
if (part == cep) {
part_found = true;
break;
}
}
if (!part_found) {
equal = false;
break;
}
}
} else
equal = false;
if (editor) if (editor)
{ {
if (editor->setParts(cep_list)) bool success = true;
if (equal == false) {
success = editor->setParts(cep_list);
}
if (success)
{ {
m_tools_dock_stack->insertWidget(1, editor); m_tools_dock_stack->insertWidget(1, editor);
m_tools_dock_stack -> setCurrentIndex(1); m_tools_dock_stack -> setCurrentIndex(1);