From 859bf7f645853ed37d8c51df23eef51863b47d22 Mon Sep 17 00:00:00 2001 From: Simon De Backer Date: Sun, 1 Nov 2020 19:10:30 +0100 Subject: [PATCH] Mod clazy checks range-loop you're using C++11 range-loops with non-const Qt containers (potential detach). adding missing & --- .../fileelementcollectionitem.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sources/ElementsCollection/fileelementcollectionitem.cpp b/sources/ElementsCollection/fileelementcollectionitem.cpp index f3f7f63a0..7cf06651f 100644 --- a/sources/ElementsCollection/fileelementcollectionitem.cpp +++ b/sources/ElementsCollection/fileelementcollectionitem.cpp @@ -282,9 +282,8 @@ void FileElementCollectionItem::setUpData() ElementsLocation loc(collectionPath()); DiagramContext context = loc.elementInformations(); QStringList search_list; - for (QString key : context.keys()) { - search_list.append(context.value(key).toString()); - } + for (QString& key : context.keys()) + { search_list.append(context.value(key).toString()); } search_list.append(localName(loc)); setData(search_list.join(" ")); } @@ -352,8 +351,8 @@ void FileElementCollectionItem::populate(bool set_data, bool hide_element) QDir dir (fileSystemPath()); //Get all directory in this directory. - for(auto str : dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot, - QDir::Name)) + for (auto& str : + dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot, QDir::Name)) { FileElementCollectionItem *feci = new FileElementCollectionItem(); appendRow(feci); @@ -367,8 +366,8 @@ void FileElementCollectionItem::populate(bool set_data, bool hide_element) //Get all elmt file in this directory dir.setNameFilters(QStringList() << "*.elmt"); - for(auto str : dir.entryList(QDir::Files | QDir::NoDotAndDotDot, - QDir::Name)) + for (auto& str : + dir.entryList(QDir::Files | QDir::NoDotAndDotDot, QDir::Name)) { FileElementCollectionItem *feci = new FileElementCollectionItem(); appendRow(feci);