Add a Toolbars settings page: icon size, text with icons, lock

A new page in Configurer QElectroTech, "Barres d'outils", sets for
every window (folio editor, element editor, title block editor):
- the icon size: default, 16, 24, 32 or 48 px
- the buttons: icon only, text beside the icon, or text under it
- locking the toolbars so they can't be dragged out of place

OK applies it to the open windows at once. The defaults are Qt's
own, and a default value removes its key, so nothing changes for
anyone who never opens the page. A toolbar inside a panel is left
alone; only the window's own toolbars are locked.

New test tst_toolbarsettings: defaults change nothing, saved values
reach every toolbar of an open window, back to defaults removes the
keys.

Third stage of discussion #1319.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ispyisail
2026-10-06 09:14:35 +13:00
parent 85342f4b56
commit 9eef8f95c9
11 changed files with 447 additions and 0 deletions
+2
View File
@@ -54,6 +54,7 @@
#include "../../dxf/dxftoelmt.h"
#include "../../qet_elementscaler/qet_elementscaler.h"
#include "../UndoCommand/openelmtcommand.h"
#include "../../toolbarsettings.h"
#include <QSettings>
#include <QActionGroup>
@@ -89,6 +90,7 @@ QETElementEditor::QETElementEditor(QWidget *parent) :
readSettings(); // restoreGeometry before show()
show();
readSettingsState(); // restoreState() must be called after show() in Qt6
ToolbarSettings::applyTo(this);
}
/**
+2
View File
@@ -42,6 +42,7 @@
#include "ui/configpage/generalconfigurationpage.h"
#include "ui/configpage/shortcutsconfigpage.h"
#include "ui/configpage/shortcutbarconfigpage.h"
#include "ui/configpage/toolbarsconfigpage.h"
#include "machine_info.h"
#include "TerminalStrip/ui/terminalstripeditorwindow.h"
#include "qetversion.h"
@@ -2225,6 +2226,7 @@ void QETApp::configureQET()
cd.addPage(new PrintConfigPage());
cd.addPage(new ShortcutsConfigPage());
cd.addPage(new ShortcutBarConfigPage());
cd.addPage(new ToolbarsConfigPage());
#ifdef QET_SPACEMOUSE_SUPPORT
cd.addPage(new SpaceMouseConfigPage());
#endif
+2
View File
@@ -85,6 +85,7 @@
#include "wiringlistexport.h"
#include "ui/wiringlistdialog.h"
#include "ui/terminalnumberingdialog.h"
#include "toolbarsettings.h"
#include <QDateTime>
#include <QDebug>
#include <QDir>
@@ -186,6 +187,7 @@ QETDiagramEditor::QETDiagramEditor(const QStringList &files, QWidget *parent) :
readSettings(); // restoreGeometry before show()
show();
readSettingsState(); // restoreState() must be called after show() in Qt6
ToolbarSettings::applyTo(this);
#ifdef QET_HAS_SCRIPTING
setUpLiveIndicator();
setUpMacroRecorder();
+2
View File
@@ -27,6 +27,7 @@
#include "templatelocationsaver.h"
#include "templatelogomanager.h"
#include "templateview.h"
#include "../toolbarsettings.h"
/**
@param parent parent QWidget of this window
@@ -46,6 +47,7 @@ QETTitleBlockTemplateEditor::QETTitleBlockTemplateEditor(QWidget *parent) :
initActions();
initMenus();
initToolbars();
ToolbarSettings::applyTo(this);
readSettings();
}
+102
View File
@@ -0,0 +1,102 @@
/*
Copyright 2006-2026 The QElectroTech Team
This file is part of QElectroTech.
QElectroTech is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
QElectroTech is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with QElectroTech. If not, see <http://www.gnu.org/licenses/>.
*/
#include "toolbarsettings.h"
#include <QApplication>
#include <QMainWindow>
#include <QSettings>
#include <QToolBar>
namespace {
const QString ICON_SIZE = QStringLiteral("toolbars/icon_size");
const QString BUTTON_STYLE = QStringLiteral("toolbars/button_style");
const QString LOCKED = QStringLiteral("toolbars/locked");
}
int ToolbarSettings::iconSize()
{
return QSettings().value(ICON_SIZE, 0).toInt();
}
Qt::ToolButtonStyle ToolbarSettings::buttonStyle()
{
const int style = QSettings().value(BUTTON_STYLE, int(Qt::ToolButtonIconOnly)).toInt();
switch (style) {
case Qt::ToolButtonTextBesideIcon:
case Qt::ToolButtonTextUnderIcon:
return Qt::ToolButtonStyle(style);
default:
return Qt::ToolButtonIconOnly;
}
}
bool ToolbarSettings::locked()
{
return QSettings().value(LOCKED, false).toBool();
}
/**
@brief ToolbarSettings::save
Store the three values; a default value removes its key.
*/
void ToolbarSettings::save(int icon_size, Qt::ToolButtonStyle style, bool locked)
{
QSettings settings;
if (icon_size > 0) settings.setValue(ICON_SIZE, icon_size);
else settings.remove(ICON_SIZE);
if (style != Qt::ToolButtonIconOnly) settings.setValue(BUTTON_STYLE, int(style));
else settings.remove(BUTTON_STYLE);
if (locked) settings.setValue(LOCKED, true);
else settings.remove(LOCKED);
}
/**
@brief ToolbarSettings::applyTo
Apply the settings to \a window and its toolbars. The window passes
its icon size and button style on to every toolbar that has none of
its own; an invalid size gives the style's default back.
*/
void ToolbarSettings::applyTo(QMainWindow *window)
{
if (!window) {
return;
}
const int size = iconSize();
window->setIconSize(size > 0 ? QSize(size, size) : QSize());
window->setToolButtonStyle(buttonStyle());
const bool movable = !locked();
for (QToolBar *toolbar : window->findChildren<QToolBar *>()) {
//Not a toolbar inside a panel: only the window's own
if (window->toolBarArea(toolbar) != Qt::NoToolBarArea) {
toolbar->setMovable(movable);
}
}
}
/**
@brief ToolbarSettings::applyToAll
Apply the settings to every open window, after they change.
*/
void ToolbarSettings::applyToAll()
{
for (QWidget *widget : QApplication::topLevelWidgets()) {
if (auto *window = qobject_cast<QMainWindow *>(widget)) {
applyTo(window);
}
}
}
+45
View File
@@ -0,0 +1,45 @@
/*
Copyright 2006-2026 The QElectroTech Team
This file is part of QElectroTech.
QElectroTech is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
QElectroTech is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with QElectroTech. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef TOOLBARSETTINGS_H
#define TOOLBARSETTINGS_H
#include <QSize>
#include <Qt>
class QMainWindow;
/**
@brief How every window's toolbars look: icon size, text with the
icons, and whether they can be moved. Stored in QSettings; a value
the user never changed keeps Qt's default, so nothing changes for
anyone who does not set one.
*/
class ToolbarSettings
{
public:
/// Icon size in pixels, or 0 for the style's default size
static int iconSize();
static Qt::ToolButtonStyle buttonStyle();
static bool locked();
static void save(int icon_size, Qt::ToolButtonStyle style, bool locked);
static void applyTo(QMainWindow *window);
static void applyToAll();
};
#endif // TOOLBARSETTINGS_H
@@ -0,0 +1,88 @@
/*
Copyright 2006-2026 The QElectroTech Team
This file is part of QElectroTech.
QElectroTech is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
QElectroTech is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with QElectroTech. If not, see <http://www.gnu.org/licenses/>.
*/
#include "toolbarsconfigpage.h"
#include "../../qeticons.h"
#include "../../toolbarsettings.h"
#include <QCheckBox>
#include <QComboBox>
#include <QFormLayout>
#include <QFrame>
#include <QLabel>
#include <QVBoxLayout>
ToolbarsConfigPage::ToolbarsConfigPage(QWidget *parent) :
ConfigPage(parent)
{
auto *vlayout = new QVBoxLayout(this);
vlayout->addWidget(new QLabel(title(), this));
auto *line = new QFrame(this);
line->setFrameShape(QFrame::HLine);
vlayout->addWidget(line);
m_icon_size = new QComboBox(this);
m_icon_size->setObjectName(QStringLiteral("iconSizeCombo"));
m_icon_size->addItem(tr("Par défaut"), 0);
m_icon_size->addItem(tr("Petites (16 px)"), 16);
m_icon_size->addItem(tr("Moyennes (24 px)"), 24);
m_icon_size->addItem(tr("Grandes (32 px)"), 32);
m_icon_size->addItem(tr("Très grandes (48 px)"), 48);
const int size_index = m_icon_size->findData(ToolbarSettings::iconSize());
m_icon_size->setCurrentIndex(size_index < 0 ? 0 : size_index);
m_button_style = new QComboBox(this);
m_button_style->setObjectName(QStringLiteral("buttonStyleCombo"));
m_button_style->addItem(tr("Icône seule"), int(Qt::ToolButtonIconOnly));
m_button_style->addItem(tr("Texte à côté de l'icône"), int(Qt::ToolButtonTextBesideIcon));
m_button_style->addItem(tr("Texte sous l'icône"), int(Qt::ToolButtonTextUnderIcon));
m_button_style->setCurrentIndex(m_button_style->findData(int(ToolbarSettings::buttonStyle())));
m_locked = new QCheckBox(tr("Verrouiller les barres d'outils (elles ne peuvent plus être déplacées)"), this);
m_locked->setObjectName(QStringLiteral("lockedCheck"));
m_locked->setChecked(ToolbarSettings::locked());
auto *form = new QFormLayout();
form->addRow(tr("Taille des icônes :"), m_icon_size);
form->addRow(tr("Boutons :"), m_button_style);
form->addRow(m_locked);
vlayout->addLayout(form);
auto *hint = new QLabel(tr("Pour afficher ou masquer une barre d'outils, faites un clic droit sur une barre d'outils."), this);
hint->setWordWrap(true);
vlayout->addWidget(hint);
vlayout->addStretch();
}
void ToolbarsConfigPage::applyConf()
{
ToolbarSettings::save(m_icon_size->currentData().toInt(),
Qt::ToolButtonStyle(m_button_style->currentData().toInt()),
m_locked->isChecked());
ToolbarSettings::applyToAll();
}
QString ToolbarsConfigPage::title() const
{
return tr("Barres d'outils", "configuration page title");
}
QIcon ToolbarsConfigPage::icon() const
{
return QET::Icons::ConfigureToolbars;
}
@@ -0,0 +1,49 @@
/*
Copyright 2006-2026 The QElectroTech Team
This file is part of QElectroTech.
QElectroTech is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
QElectroTech is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with QElectroTech. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef TOOLBARSCONFIGPAGE_H
#define TOOLBARSCONFIGPAGE_H
#include "configpage.h"
class QCheckBox;
class QComboBox;
/**
@brief The ToolbarsConfigPage class
Toolbar icon size, text with the icons, and locking the toolbars in
place, for every window. Saved and applied to the open windows by
applyConf().
*/
class ToolbarsConfigPage : public ConfigPage
{
Q_OBJECT
public:
explicit ToolbarsConfigPage(QWidget *parent = nullptr);
void applyConf() override;
QString title() const override;
QIcon icon() const override;
private:
QComboBox *m_icon_size;
QComboBox *m_button_style;
QCheckBox *m_locked;
};
#endif // TOOLBARSCONFIGPAGE_H