From c5edd0a54b7952548fdcc88a872ce39858a94533 Mon Sep 17 00:00:00 2001 From: Laurent Trinques Date: Tue, 22 Sep 2026 08:19:23 +0200 Subject: [PATCH] CI: try to fix 404 error on downlad page --- .github/workflows/windows-msi.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows-msi.yml b/.github/workflows/windows-msi.yml index 21c179dd5..9f26c54a4 100644 --- a/.github/workflows/windows-msi.yml +++ b/.github/workflows/windows-msi.yml @@ -381,7 +381,20 @@ jobs: deploy-pages: needs: build-msi runs-on: ubuntu-latest - if: always() && needs.build-msi.result == 'success' + # Regenerate the page whenever the MSI job actually ran (success OR + # packaging/signing failure) — not only on full success. + # generate-page.py queries the published assets on the "nightly" + # release itself (line 407: `gh release view nightly --json assets`), + # so it already handles a missing MSI natively (empty MSI_NAME -> no + # MSI button on the page). The page only needs the exe/zip already + # published by windows-build.yml, independent of the MSI's fate. + # Only "skipped"/"cancelled" are excluded: if build-msi never ran at + # all (e.g. Windows Build itself failed), there is nothing new to + # publish and regenerating the page would be pointless. + if: > + always() && + needs.build-msi.result != 'skipped' && + needs.build-msi.result != 'cancelled' permissions: contents: write pages: write