Add editing the information of several elements at once (#1439)

Selecting several elements left the Selection properties panel blank and
Edit (Ctrl+E) disabled, so giving many elements the same supplier or
manufacturer meant editing them one by one.

The panel now shows the Information fields for two or more elements, or
for elements selected with other items (left unchanged, and counted in
the panel's header). Ctrl+E opens the same editor as a dialog when only
elements are selected.

- A field shows the value every element shares, or "Multiple values".
  Left alone, each element keeps its own value; typed text goes to every
  element; the erase box clears the field on every element.
- A restore button per field, and Reset, bring back the values the
  elements had.
- One apply is one undo step. The keystrokes typed in the panel merge
  into one step but never into an earlier change of the same elements
  (a paste of element information, another edit).
- Numbering scheme, label freezing and the number picker are left out:
  they are about one element. Custom properties are kept as they are.

Also:
- An element's own texts, selected with it by Select all, count as part
  of the element, not as other items.
- ElementInfoWidget::reset(): Reset in the element dialog now brings back
  the Information tab's values; it did nothing.
- The panel opens an element's editor on the tab picked last, instead of
  the first tab, after the selection went to something else and back.

Test: tst_multielementinfo.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ispyisail
2026-10-18 21:44:00 +13:00
parent e46bb97c5b
commit ce0798bb18
12 changed files with 1506 additions and 48 deletions
+26 -34
View File
@@ -64,6 +64,7 @@
#include "factory/qetgraphicstablefactory.h"
#include "print/projectprintwindow.h"
#include "project/projectpropertieshandler.h"
#include "ui/multielementinfowidget.h"
#include "ui/projectpropertiesdialog.h"
#include "projectview.h"
#include "qetproject.h"
@@ -3085,6 +3086,21 @@ void QETDiagramEditor::slot_updateUndoStack()
undo_group.setActiveStack(currentProjectView()->project()->undoStack());
}
namespace {
/**
@return the elements of @p diagram's selection which take information
*/
QList<Element *> selectedInformationElements(Diagram *diagram)
{
QList<Element *> list;
for (Element *element : DiagramContent(diagram).m_elements) {
if (MultiElementInfoWidget::takesInformations(element))
list << element;
}
return list;
}
} // namespace
/**
@brief QETDiagramEditor::slot_updateComplexActions
Manage the actions that need some conditions to be enabled or not.
@@ -3211,7 +3227,16 @@ void QETDiagramEditor::slot_updateComplexActions()
+ selected_conductors_count
+ selected_cables;
if (selected_editable == 1)
//Several elements and nothing else: edit their information together (#1439)
if (!ro && selected_editable > 1 && selected_editable == selected_elements_count
&& selectedInformationElements(diagram_).size() > 1)
{
m_edit_selection -> setEnabled(true);
m_edit_selection -> setText(tr("Edit the information of the elements",
"edit several elements"));
m_edit_selection -> setIcon(QET::Icons::ElementEdit);
}
else if (selected_editable == 1)
{
m_edit_selection -> setEnabled(true);
//edit element
@@ -3323,39 +3348,6 @@ void QETDiagramEditor::slot_updateModeActions()
}
}
namespace {
/**
@return true if @p element has information the user can edit, the
same element kinds ElementPropertiesWidget gives an ElementInfoWidget.
Plain slaves and folio reports take theirs from what they are linked to.
*/
bool takesElementInformations(const Element *element)
{
switch (element->linkType()) {
case Element::Simple:
case Element::Thumbnail:
case Element::Master:
case Element::Terminale:
return true;
default:
return false;
}
}
/**
@return the elements of @p diagram's selection which take information
*/
QList<Element *> selectedInformationElements(Diagram *diagram)
{
QList<Element *> list;
for (Element *element : DiagramContent(diagram).m_elements) {
if (takesElementInformations(element))
list << element;
}
return list;
}
} // namespace
/**
@brief QETDiagramEditor::slot_updatePasteAction
Gere les actions ayant besoin du presse-papier