From cffec76018caabb9f6b93ad36c3040bc40c52ba6 Mon Sep 17 00:00:00 2001 From: Simon De Backer Date: Sat, 5 Dec 2020 08:24:35 +0100 Subject: [PATCH] Fix warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 /* The largest number rand will return (same as INT_MAX). */ #define RAND_MAX 2147483647 (static_cast(quint32) / int * 8) why cast an int to a float to then divide by an int? just divide the int by an int. --- SingleApplication/singleapplication.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SingleApplication/singleapplication.cpp b/SingleApplication/singleapplication.cpp index 1e5da497d..461592ebe 100644 --- a/SingleApplication/singleapplication.cpp +++ b/SingleApplication/singleapplication.cpp @@ -113,7 +113,7 @@ SingleApplication::SingleApplication( int &argc, char *argv[], bool allowSeconda #pragma message("@TODO remove code for QT 5.10 or later") #endif quint32 value = QRandomGenerator::global()->generate(); - QThread::sleep( 8 + static_cast ( static_cast ( value ) / RAND_MAX * 10 ) ); + QThread::sleep(8 + static_cast(value / RAND_MAX * 10)); #endif }