From d889a384aaf2adab73a475f6b01b35ce6205dbf4 Mon Sep 17 00:00:00 2001 From: Laurent Trinques Date: Wed, 23 Sep 2026 13:50:49 +0200 Subject: [PATCH] Revert "fix: harden project database export" --- .github/workflows/windows-build.yml | 1 + INSTALL.md | 1 + sources/dataBase/projectdatabase.cpp | 5 ++--- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index 94b4bca2a..4cc90c82a 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -121,6 +121,7 @@ jobs: -DQET_EXPORT_PROJECT_DB=ON \ -DCMAKE_C_COMPILER_LAUNCHER=/ucrt64/bin/ccache \ -DCMAKE_CXX_COMPILER_LAUNCHER=/ucrt64/bin/ccache \ + .. ninja -j"$NPROC" diff --git a/INSTALL.md b/INSTALL.md index 4dc4d4387..ef4eaef78 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -100,6 +100,7 @@ the closest match. sudo apt install \ build-essential cmake ninja-build git \ qt6-base-dev qt6-base-private-dev qt6-tools-dev qt6-tools-dev-tools \ + libkf6coreaddons-dev libkf6widgetsaddons-dev ``` diff --git a/sources/dataBase/projectdatabase.cpp b/sources/dataBase/projectdatabase.cpp index e1d8dbf82..75bff0ed6 100644 --- a/sources/dataBase/projectdatabase.cpp +++ b/sources/dataBase/projectdatabase.cpp @@ -1335,10 +1335,9 @@ void projectDataBase::exportDb(projectDataBase *db, // VACUUM INTO creates a standalone copy of the current database without // requiring access to the SQLite driver's native connection handle. + const auto escaped_path = path_.replace("'", "''"); QSqlQuery query(db->m_data_base); - query.prepare("VACUUM INTO ?"); - query.bindValue(0, path_); - if (!query.exec()) { + if (!query.exec("VACUUM INTO '" % escaped_path % "'")) { qWarning() << "Unable to export project database:" << query.lastError().text(); } }