mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2025-12-17 20:50:34 +01:00
Try Clazy fix-its
clazy is a compiler plugin which allows clang to understand Qt semantics. You get more than 50 Qt related compiler warnings, ranging from unneeded memory allocations to misusage of API, including fix-its for automatic refactoring. https://invent.kde.org/sdk/clazy
This commit is contained in:
@@ -779,7 +779,8 @@ void ElementsCollectionWidget::search()
|
||||
const QStringList text_list = text.split("+", Qt::SkipEmptyParts);
|
||||
#endif
|
||||
QModelIndexList match_index;
|
||||
for (QString txt : text_list) {
|
||||
for (const QString& txt : text_list)
|
||||
{
|
||||
match_index << m_model->match(m_showed_index.isValid()
|
||||
? m_model->index(0,0,m_showed_index)
|
||||
: m_model->index(0,0),
|
||||
@@ -790,7 +791,7 @@ void ElementsCollectionWidget::search()
|
||||
| Qt::MatchRecursive);
|
||||
}
|
||||
|
||||
for(QModelIndex index : match_index)
|
||||
for (QModelIndex index : std::as_const(match_index))
|
||||
showAndExpandItem(index);
|
||||
}
|
||||
|
||||
|
||||
@@ -41,8 +41,8 @@ ElementsTreeView::ElementsTreeView(QWidget *parent) :
|
||||
QPalette qp = palette();
|
||||
qp.setColor(QPalette::Text, Qt::black);
|
||||
qp.setColor(QPalette::Base, Qt::white);
|
||||
qp.setColor(QPalette::AlternateBase, QColor("#e8e8e8"));
|
||||
qp.setColor(QPalette::Highlight, QColor("#678db2"));
|
||||
qp.setColor(QPalette::AlternateBase, QColor(0xe8e8e8));
|
||||
qp.setColor(QPalette::Highlight, QColor(0x678db2));
|
||||
qp.setColor(QPalette::HighlightedText, Qt::black);
|
||||
setPalette(qp);
|
||||
}
|
||||
|
||||
@@ -206,7 +206,8 @@ void XmlProjectElementCollectionItem::setUpData()
|
||||
ElementsLocation location(embeddedPath(), m_project);
|
||||
DiagramContext context = location.elementInformations();
|
||||
QStringList search_list;
|
||||
for (QString key : context.keys()) {
|
||||
for (const QString& key : context.keys())
|
||||
{
|
||||
search_list.append(context.value(key).toString());
|
||||
}
|
||||
search_list.append(localName());
|
||||
|
||||
Reference in New Issue
Block a user