kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2025-12-17 20:50:34 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Try Clazy fix-its

Browse Source 
clazy is a compiler plugin which allows clang to understand Qt
semantics. You get more than 50 Qt related compiler warnings, ranging
from unneeded memory allocations to misusage of API, including fix-its
for automatic refactoring.

https://invent.kde.org/sdk/clazy
This commit is contained in:
Laurent Trinques
2025-02-14 15:52:23 +01:00
parent adcf77e34a
commit dba7caed30
88 changed files with 512 additions and 409 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
sources/SearchAndReplace/ui/searchandreplacewidget.cpp
View File

@@ -127,7 +127,7 @@ void SearchAndReplaceWidget::clear()
qDeleteAll(m_conductor_hash.keys());
m_conductor_hash.clear();
for (QTreeWidgetItem *qtwi : m_category_qtwi)
for (QTreeWidgetItem* qtwi : std::as_const(m_category_qtwi))
qtwi->setHidden(false);
ui->m_tree_widget->collapseAll();
@@ -284,18 +284,17 @@ void SearchAndReplaceWidget::fillItemsList()
dc += DiagramContent(diagram, false);
}
for (Element *elmt : dc.m_elements)
addElement(elmt);
for (Element* elmt : std::as_const(dc.m_elements)) addElement(elmt);
//Sort child of each "element type" tree item.
//we hide, "element type" tree item, if they do not have children
for(QTreeWidgetItem *qtwi : m_qtwi_elmts)
for (QTreeWidgetItem* qtwi : std::as_const(m_qtwi_elmts))
{
qtwi->sortChildren(0, Qt::AscendingOrder);
qtwi->setHidden(qtwi->childCount() ? false : true);
}
for (IndependentTextItem *iti : dc.m_text_fields)
for (IndependentTextItem* iti : std::as_const(dc.m_text_fields))
{
QTreeWidgetItem *qtwi = new QTreeWidgetItem(m_indi_text_qtwi);
qtwi->setText(0, iti->toPlainText());
@@ -306,7 +305,7 @@ void SearchAndReplaceWidget::fillItemsList()
m_indi_text_qtwi->sortChildren(0, Qt::AscendingOrder);
for (Conductor *c : dc.m_potential_conductors)
for (Conductor* c : std::as_const(dc.m_potential_conductors))
{
QTreeWidgetItem *qtwi = new QTreeWidgetItem(m_conductor_qtwi);
qtwi->setText(0, c->properties().text);
@@ -379,7 +378,8 @@ void SearchAndReplaceWidget::search()
(*it)->setHidden(false);
}
for (QTreeWidgetItem *item : m_category_qtwi) {
for (QTreeWidgetItem* item : std::as_const(m_category_qtwi))
{
item->setExpanded(false);
}
m_root_qtwi->setExpanded(true);
@@ -442,9 +442,9 @@ void SearchAndReplaceWidget::search()
}
QPalette background = ui->m_search_le->palette();
background.setColor(QPalette::Base, match
? QColor("#E0FFF0")
: QColor("#FFE0EF"));
background.setColor(
QPalette::Base,
match ? QColor(0xE0FFF0) : QColor(0xFFE0EF));
ui->m_search_le->setPalette(background);
//Go to the first occurrence
@@ -488,7 +488,8 @@ void SearchAndReplaceWidget::setUpConenctions()
connect(m_select_elements, &QAction::triggered, [this]()
{
DiagramContent dc(m_diagram_hash.value(ui->m_tree_widget->currentItem()), false);
for (auto elmt : dc.m_elements) {
for (auto elmt : std::as_const(dc.m_elements))
{
if (auto item = m_element_hash.key(elmt)) {
item->setCheckState(0, Qt::Checked);
}
@@ -508,7 +509,8 @@ void SearchAndReplaceWidget::setUpConenctions()
connect(m_select_texts, &QAction::triggered, [this]()
{
DiagramContent dc(m_diagram_hash.value(ui->m_tree_widget->currentItem()), false);
for (auto text : dc.m_text_fields) {
for (auto text : std::as_const(dc.m_text_fields))
{
if (auto item = m_text_hash.key(text)) {
item->setCheckState(0, Qt::Checked);
}
@@ -858,7 +860,8 @@ QStringList SearchAndReplaceWidget::searchTerms(Diagram *diagram)
list.append(prop.indexrev);
list.append(prop.folio);
list.append(prop.date.toString());
for (QString key : prop.context.keys()) {
for (const QString& key : prop.context.keys())
{
list.append(prop.context.value(key).toString());
}
@@ -874,7 +877,7 @@ QStringList SearchAndReplaceWidget::searchTerms(Element *element)
{
QStringList list;
DiagramContext context = element->elementInformations();
for (QString key : QETInformation::elementInfoKeys())
for (const QString& key : QETInformation::elementInfoKeys())
{
QString str = context.value(key).toString();
if (!str.isEmpty()) {