kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2025-12-17 12:40:35 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Try Clazy fix-its

Browse Source 
clazy is a compiler plugin which allows clang to understand Qt
semantics. You get more than 50 Qt related compiler warnings, ranging
from unneeded memory allocations to misusage of API, including fix-its
for automatic refactoring.

https://invent.kde.org/sdk/clazy
This commit is contained in:
Laurent Trinques
2025-02-14 15:52:23 +01:00
parent adcf77e34a
commit dba7caed30
88 changed files with 512 additions and 409 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sources/TerminalStrip/GraphicsItem/terminalstripdrawer.cpp
View File

@@ -241,7 +241,8 @@ int TerminalStripDrawer::height() const
height_ = std::max(height_, m_pattern->m_spacer_rect.y() + m_pattern->m_spacer_rect.height());
for (const auto &rect : m_pattern->m_terminal_rect) {
for (const auto& rect : std::as_const(m_pattern->m_terminal_rect))
{
height_ = std::max(height_, rect.y() + rect.height());
}

6
sources/TerminalStrip/UndoCommand/addterminalstripcommand.cpp
View File

@@ -74,7 +74,8 @@ RemoveTerminalStripCommand::~RemoveTerminalStripCommand()
void RemoveTerminalStripCommand::undo()
{
if (m_project && m_strip) {
for (auto elmt : m_elements) {
for (const auto& elmt : std::as_const(m_elements))
{
m_strip->addTerminal(elmt);
}
m_project->addTerminalStrip(m_strip);
@@ -84,7 +85,8 @@ void RemoveTerminalStripCommand::undo()
void RemoveTerminalStripCommand::redo()
{
if (m_project && m_strip) {
for (auto elmt : m_elements) {
for (const auto& elmt : std::as_const(m_elements))
{
m_strip->removeTerminal(elmt);
}
m_project->removeTerminalStrip(m_strip);

3
sources/TerminalStrip/UndoCommand/addterminaltostripcommand.cpp
View File

@@ -161,7 +161,8 @@ MoveTerminalCommand::MoveTerminalCommand(QSharedPointer<PhysicalTerminal> termin
m_new_strip {new_strip}
{
QString t_label;
for (auto real_t : terminal->realTerminals()) {
for (const auto& real_t : terminal->realTerminals())
{
if (!t_label.isEmpty())
t_label.append(", ");
t_label.append(real_t->label());

9
sources/TerminalStrip/physicalterminal.cpp
View File

@@ -31,7 +31,8 @@ PhysicalTerminal::PhysicalTerminal(TerminalStrip *parent_strip,
m_parent_terminal_strip(parent_strip),
m_real_terminal(terminals)
{
for (const auto &real_t : m_real_terminal) {
for (const auto& real_t : std::as_const(m_real_terminal))
{
if (real_t) {
real_t->setPhysicalTerminal(sharedRef());
}
@@ -86,7 +87,8 @@ QDomElement PhysicalTerminal::toXml(QDomDocument &parent_document) const
*/
void PhysicalTerminal::setTerminals(const QVector<QSharedPointer<RealTerminal>> &terminals) {
m_real_terminal = terminals;
for (const auto &real_t : m_real_terminal) {
for (const auto& real_t : std::as_const(m_real_terminal))
{
if (real_t) {
real_t->setPhysicalTerminal(sharedRef());
}
@@ -148,7 +150,8 @@ void PhysicalTerminal::setParentStrip(TerminalStrip *strip)
PhysicalTerminal::~PhysicalTerminal()
{
for (const auto &real_t : m_real_terminal) {
for (const auto& real_t : std::as_const(m_real_terminal))
{
if (real_t) {
real_t->setPhysicalTerminal(QSharedPointer<PhysicalTerminal>());
}

3
sources/TerminalStrip/ui/freeterminalmodel.cpp
View File

@@ -315,7 +315,8 @@ void FreeTerminalModel::fillTerminalVector()
b->elementData().m_informations.value(QETInformation::ELMT_LABEL).toString());
});
for (const auto &terminal_ : free_terminal_vector) {
for (const auto& terminal_ : std::as_const(free_terminal_vector))
{
m_terminal_vector.append(terminal_->realTerminal());
m_real_t_data.append(modelRealTerminalData::data(terminal_->realTerminal()));
}

2
sources/TerminalStrip/ui/terminalstripeditor.cpp
View File

@@ -456,7 +456,7 @@ void TerminalStripEditor::on_m_group_terminals_pb_clicked()
QVector<QSharedPointer<RealTerminal>> vector_;
int count_ = 0;
for (const auto & mrtd : mrtd_vector)
for (const auto& mrtd : std::as_const(mrtd_vector))
{
const auto real_t = mrtd.real_terminal.toStrongRef();
vector_.append(real_t);

2
sources/TerminalStrip/ui/terminalstripmodel.cpp
View File

@@ -428,7 +428,7 @@ modelRealTerminalData TerminalStripModel::modelRealTerminalDataForIndex(const QM
void TerminalStripModel::buildBridgePixmap(const QSize &pixmap_size)
{
m_bridges_pixmaps.clear();
for (auto color_ : TerminalStripBridge::bridgeColor())
for (const auto& color_ : TerminalStripBridge::bridgeColor())
{
QPen pen;
pen.setColor(color_);