mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2025-12-17 12:40:35 +01:00
Try Clazy fix-its
clazy is a compiler plugin which allows clang to understand Qt semantics. You get more than 50 Qt related compiler warnings, ranging from unneeded memory allocations to misusage of API, including fix-its for automatic refactoring. https://invent.kde.org/sdk/clazy
This commit is contained in:
@@ -74,7 +74,8 @@ RemoveTerminalStripCommand::~RemoveTerminalStripCommand()
|
||||
void RemoveTerminalStripCommand::undo()
|
||||
{
|
||||
if (m_project && m_strip) {
|
||||
for (auto elmt : m_elements) {
|
||||
for (const auto& elmt : std::as_const(m_elements))
|
||||
{
|
||||
m_strip->addTerminal(elmt);
|
||||
}
|
||||
m_project->addTerminalStrip(m_strip);
|
||||
@@ -84,7 +85,8 @@ void RemoveTerminalStripCommand::undo()
|
||||
void RemoveTerminalStripCommand::redo()
|
||||
{
|
||||
if (m_project && m_strip) {
|
||||
for (auto elmt : m_elements) {
|
||||
for (const auto& elmt : std::as_const(m_elements))
|
||||
{
|
||||
m_strip->removeTerminal(elmt);
|
||||
}
|
||||
m_project->removeTerminalStrip(m_strip);
|
||||
|
||||
@@ -161,7 +161,8 @@ MoveTerminalCommand::MoveTerminalCommand(QSharedPointer<PhysicalTerminal> termin
|
||||
m_new_strip {new_strip}
|
||||
{
|
||||
QString t_label;
|
||||
for (auto real_t : terminal->realTerminals()) {
|
||||
for (const auto& real_t : terminal->realTerminals())
|
||||
{
|
||||
if (!t_label.isEmpty())
|
||||
t_label.append(", ");
|
||||
t_label.append(real_t->label());
|
||||
|
||||
Reference in New Issue
Block a user