Try Clazy fix-its

clazy is a compiler plugin which allows clang to understand Qt
semantics. You get more than 50 Qt related compiler warnings, ranging
from unneeded memory allocations to misusage of API, including fix-its
for automatic refactoring.

https://invent.kde.org/sdk/clazy
This commit is contained in:
Laurent Trinques
2025-02-14 15:52:23 +01:00
parent adcf77e34a
commit dba7caed30
88 changed files with 512 additions and 409 deletions

View File

@@ -67,7 +67,8 @@ QString SummaryQueryWidget::queryStr() const
QString column;
bool first = true;
for (auto key: keys) {
for (const auto& key : std::as_const(keys))
{
if (first) {
first = false;
} else {
@@ -104,9 +105,9 @@ void SummaryQueryWidget::setQuery(const QString &query)
//Get the select -> the item in the right list
QStringList split = select.split(",");
for (auto str : split)
for (const auto& str : std::as_const(split))
{
for (auto item : m_items_list)
for (auto item : std::as_const(m_items_list))
{
if (item->data(Qt::UserRole).toString() == str) {
ui->m_available_list->takeItem(ui->m_available_list->row(item));
@@ -123,7 +124,7 @@ void SummaryQueryWidget::setQuery(const QString &query)
*/
void SummaryQueryWidget::setUpItems()
{
for (auto key : QETInformation::diagramInfoKeys())
for (const auto& key : QETInformation::diagramInfoKeys())
{
if (key == "filename" || key == "display_folio") {
continue;