mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2025-12-17 20:50:34 +01:00
Try Clazy fix-its
clazy is a compiler plugin which allows clang to understand Qt semantics. You get more than 50 Qt related compiler warnings, ranging from unneeded memory allocations to misusage of API, including fix-its for automatic refactoring. https://invent.kde.org/sdk/clazy
This commit is contained in:
@@ -613,13 +613,13 @@ void ElementPrimitiveDecorator::addHandler()
|
||||
if (m_handler_vector.isEmpty() && scene())
|
||||
{
|
||||
m_handler_vector = QetGraphicsHandlerItem::handlerForPoint(mapFromScene(getResizingsPoints()));
|
||||
|
||||
for(QetGraphicsHandlerItem *handler : m_handler_vector)
|
||||
{
|
||||
scene()->addItem(handler);
|
||||
handler->setColor(Qt::darkGreen);
|
||||
handler->installSceneEventFilter(this);
|
||||
handler->setZValue(this->zValue()+1);
|
||||
|
||||
for (QetGraphicsHandlerItem* handler : std::as_const(m_handler_vector))
|
||||
{
|
||||
scene()->addItem(handler);
|
||||
handler->setColor(Qt::darkGreen);
|
||||
handler->installSceneEventFilter(this);
|
||||
handler->setZValue(this->zValue() + 1);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -727,12 +727,12 @@ QVariant ElementPrimitiveDecorator::itemChange(QGraphicsItem::GraphicsItemChange
|
||||
else if (change == ItemVisibleHasChanged)
|
||||
{
|
||||
bool visible = value.toBool();
|
||||
for(QetGraphicsHandlerItem *qghi : m_handler_vector)
|
||||
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
|
||||
qghi->setVisible(visible);
|
||||
}
|
||||
else if (change == ItemZValueHasChanged && !m_handler_vector.isEmpty())
|
||||
{
|
||||
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
|
||||
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
|
||||
qghi->setZValue(this->zValue()+1);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user