kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2025-12-21 16:50:53 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Try Clazy fix-its

Browse Source 
clazy is a compiler plugin which allows clang to understand Qt
semantics. You get more than 50 Qt related compiler warnings, ranging
from unneeded memory allocations to misusage of API, including fix-its
for automatic refactoring.

https://invent.kde.org/sdk/clazy
This commit is contained in:
Laurent Trinques
2025-02-14 15:52:23 +01:00
parent adcf77e34a
commit dba7caed30
88 changed files with 512 additions and 409 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sources/editor/graphicspart/customelementgraphicpart.cpp
View File

@@ -530,7 +530,7 @@ void CustomElementGraphicPart::stylesFromXml(const QDomElement &qde)
//Check each pair of style
QRegularExpression rx("^\\s*([a-z-]+)\\s*:\\s*([a-zA-Z-]+)\\s*$");
for (auto style : styles)
for (const auto& style : std::as_const(styles))
{
auto rx_match = rx.match(style);
if (!rx_match.hasMatch()) {

8
sources/editor/graphicspart/partarc.cpp
View File

@@ -265,7 +265,7 @@ void PartArc::switchResizeMode()
if (m_resize_mode == 1)
{
m_resize_mode = 2;
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::darkGreen);
}
else if (m_resize_mode == 2)
@@ -276,7 +276,7 @@ void PartArc::switchResizeMode()
removeHandler();
addHandler();
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::magenta);
}
else
@@ -287,7 +287,7 @@ void PartArc::switchResizeMode()
removeHandler();
addHandler();
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::blue);
}
}
@@ -445,7 +445,7 @@ void PartArc::addHandler()
else
m_handler_vector = QetGraphicsHandlerItem::handlerForPoint(mapToScene(QetGraphicsHandlerUtility::pointsForRect(m_rect)));
for(QetGraphicsHandlerItem *handler : m_handler_vector)
for (QetGraphicsHandlerItem* handler : std::as_const(m_handler_vector))
{
QColor color = Qt::blue;
if (m_resize_mode == 2)

6
sources/editor/graphicspart/partellipse.cpp
View File

@@ -241,13 +241,13 @@ void PartEllipse::switchResizeMode()
if (m_resize_mode == 1)
{
m_resize_mode = 2;
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::darkGreen);
}
else
{
m_resize_mode = 1;
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::blue);
}
}
@@ -334,7 +334,7 @@ void PartEllipse::addHandler()
{
m_handler_vector = QetGraphicsHandlerItem::handlerForPoint(mapToScene(QetGraphicsHandlerUtility::pointsForRect(m_rect)));
for(QetGraphicsHandlerItem *handler : m_handler_vector)
for (QetGraphicsHandlerItem* handler : std::as_const(m_handler_vector))
{
QColor color = Qt::blue;
if (m_resize_mode == 2)

2
sources/editor/graphicspart/partline.cpp
View File

@@ -304,7 +304,7 @@ void PartLine::addHandler()
m_handler_vector = QetGraphicsHandlerItem::handlerForPoint(mapToScene(points_vector));
for(QetGraphicsHandlerItem *handler : m_handler_vector)
for (QetGraphicsHandlerItem* handler : std::as_const(m_handler_vector))
{
handler->setColor(Qt::blue);
scene()->addItem(handler);

10
sources/editor/graphicspart/partpolygon.cpp
View File

@@ -277,7 +277,8 @@ void PartPolygon::setClosed(bool close)
*/
void PartPolygon::setHandlerColor(QPointF pos, const QColor &color)
{
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
if (qghi->pos() == mapToScene(pos)) {
qghi->setColor(color);
}
@@ -290,7 +291,8 @@ void PartPolygon::setHandlerColor(QPointF pos, const QColor &color)
*/
void PartPolygon::resetAllHandlerColor()
{
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::blue);
}
}
@@ -380,7 +382,7 @@ void PartPolygon::contextMenuEvent(QGraphicsSceneContextMenuEvent *event)
list << m_insert_point;
if (m_handler_vector.count() > 2)
{
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
if (qghi->contains(qghi->mapFromScene(event->scenePos())))
{
@@ -476,7 +478,7 @@ void PartPolygon::addHandler()
{
m_handler_vector = QetGraphicsHandlerItem::handlerForPoint(mapToScene(m_polygon));
for(QetGraphicsHandlerItem *handler : m_handler_vector)
for (QetGraphicsHandlerItem* handler : std::as_const(m_handler_vector))
{
handler->setColor(Qt::blue);
scene()->addItem(handler);

10
sources/editor/graphicspart/partrectangle.cpp
View File

@@ -361,7 +361,7 @@ void PartRectangle::switchResizeMode()
if (m_resize_mode == 1)
{
m_resize_mode = 2;
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::darkGreen);
}
else if (m_resize_mode == 2)
@@ -370,7 +370,8 @@ void PartRectangle::switchResizeMode()
qDeleteAll(m_handler_vector);
m_handler_vector.clear();
addHandler();
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::magenta);
}
}
@@ -380,7 +381,8 @@ void PartRectangle::switchResizeMode()
qDeleteAll(m_handler_vector);
m_handler_vector.clear();
addHandler();
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::blue);
}
}
@@ -512,7 +514,7 @@ void PartRectangle::addHandler()
m_handler_vector = QetGraphicsHandlerItem::handlerForPoint(mapToScene(QetGraphicsHandlerUtility::pointForRadiusRect(m_rect, m_xRadius, m_yRadius)));
}
for (QetGraphicsHandlerItem *handler : m_handler_vector)
for (QetGraphicsHandlerItem* handler : std::as_const(m_handler_vector))
{
QColor color;
if(m_resize_mode == 1) {color = Qt::blue;}