kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2025-12-17 12:40:35 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Try Clazy fix-its

Browse Source 
clazy is a compiler plugin which allows clang to understand Qt
semantics. You get more than 50 Qt related compiler warnings, ranging
from unneeded memory allocations to misusage of API, including fix-its
for automatic refactoring.

https://invent.kde.org/sdk/clazy
This commit is contained in:
Laurent Trinques
2025-02-14 15:52:23 +01:00
parent adcf77e34a
commit dba7caed30
88 changed files with 512 additions and 409 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
sources/qetgraphicsitem/element.cpp
View File

@@ -732,7 +732,7 @@ bool Element::fromXml(QDomElement &e,
{
if (auto terminal_ = qgraphicsitem_cast<Terminal *>(qgi))
{
for(auto qde : liste_terminals)
for (auto qde : std::as_const(liste_terminals))
{
if (terminal_ -> fromXml(qde))
{
@@ -812,7 +812,7 @@ bool Element::fromXml(QDomElement &e,
//Before loading the dynamic text field,
//we remove the dynamic text field created from the description of this element, to avoid doublons.
for(DynamicElementTextItem *deti : m_dynamic_text_list)
for (DynamicElementTextItem* deti : std::as_const(m_dynamic_text_list))
delete deti;
m_dynamic_text_list.clear();
@@ -868,10 +868,10 @@ bool Element::fromXml(QDomElement &e,
//We must block the update of the alignment when loading the information
//otherwise the pos of the text will not be the same as it was at save time.
for(DynamicElementTextItem *deti : m_dynamic_text_list)
for (DynamicElementTextItem* deti : std::as_const(m_dynamic_text_list))
deti->m_block_alignment = true;
setElementInformations(dc);
for(DynamicElementTextItem *deti : m_dynamic_text_list)
for (DynamicElementTextItem* deti : std::as_const(m_dynamic_text_list))
deti->m_block_alignment = false;
m_state = QET::GIOK;
@@ -1011,15 +1011,15 @@ QDomElement Element::toXml(
//Remove the texts from group
QList<DynamicElementTextItem *> deti_list = group->texts();
for(DynamicElementTextItem *deti : deti_list)
for (DynamicElementTextItem* deti : std::as_const(deti_list))
group->removeFromGroup(deti);
//Save the texts to xml
for (DynamicElementTextItem *deti : deti_list)
for (DynamicElementTextItem* deti : std::as_const(deti_list))
dyn_text.appendChild(deti->toXml(document));
//Re add texts to group
for(DynamicElementTextItem *deti : deti_list)
for (DynamicElementTextItem* deti : std::as_const(deti_list))
group->addToGroup(deti);
//Restorr the alignment
@@ -1079,7 +1079,7 @@ void Element::removeDynamicTextItem(DynamicElementTextItem *deti)
return;
}
for(ElementTextItemGroup *group : m_texts_group)
for (ElementTextItemGroup* group : std::as_const(m_texts_group))
{
if(group->texts().contains(deti))
{