Try Clazy fix-its

clazy is a compiler plugin which allows clang to understand Qt
semantics. You get more than 50 Qt related compiler warnings, ranging
from unneeded memory allocations to misusage of API, including fix-its
for automatic refactoring.

https://invent.kde.org/sdk/clazy
This commit is contained in:
Laurent Trinques
2025-02-14 15:52:23 +01:00
parent adcf77e34a
commit dba7caed30
88 changed files with 512 additions and 409 deletions

View File

@@ -49,11 +49,14 @@ QetShapeItem::QetShapeItem(QPointF p1, QPointF p2, ShapeType type, QGraphicsItem
setAcceptHoverEvents(true);
m_pen.setStyle(Qt::SolidLine);
//ensure handlers are always above this item
connect(this, &QetShapeItem::zChanged, [this]()
{
for(QetGraphicsHandlerItem *qghi : m_handler_vector)
qghi->setZValue(this->zValue()+1);
});
connect(
this,
&QetShapeItem::zChanged,
[this]()
{
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setZValue(this->zValue() + 1);
});
m_insert_point = new QAction(tr("Ajouter un point"), this);
m_insert_point->setIcon(QET::Icons::Add);
@@ -487,7 +490,8 @@ void QetShapeItem::contextMenuEvent(QGraphicsSceneContextMenuEvent *event)
if (m_handler_vector.count() > 2)
{
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi :
std::as_const(m_handler_vector))
{
if (qghi->contains(qghi->mapFromScene(event->scenePos())))
{
@@ -520,14 +524,16 @@ void QetShapeItem::switchResizeMode()
if (m_resize_mode == 1)
{
m_resize_mode = 2;
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::darkGreen);
}
}
else
{
m_resize_mode = 1;
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::blue);
}
}
@@ -537,7 +543,7 @@ void QetShapeItem::switchResizeMode()
if (m_resize_mode == 1)
{
m_resize_mode = 2;
for (QetGraphicsHandlerItem *qghi : m_handler_vector)
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
qghi->setColor(Qt::darkGreen);
}
else if (m_resize_mode == 2)
@@ -546,7 +552,8 @@ void QetShapeItem::switchResizeMode()
qDeleteAll(m_handler_vector);
m_handler_vector.clear();
addHandler();
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::magenta);
}
}
@@ -556,10 +563,10 @@ void QetShapeItem::switchResizeMode()
qDeleteAll(m_handler_vector);
m_handler_vector.clear();
addHandler();
for (QetGraphicsHandlerItem *qghi : m_handler_vector) {
for (QetGraphicsHandlerItem* qghi : std::as_const(m_handler_vector))
{
qghi->setColor(Qt::blue);
}
}
}
}