macOS: drop obsolete lang1/ copy step

lang1/ was a leftover from the pre-Qt6 translation pipeline. Qt6/CMake now produces all .qm files directly into lang/, which is already copied above, making this step dead code.
Merge pull request #829 from jp2images/fix-macos-bundle-identifier
2026-09-22 17:34:14 +02:00 · 2026-09-09 16:02:02 +02:00 · 2026-09-09 15:57:21 +02:00 · 2026-09-09 15:54:28 +02:00 · 2026-09-09 05:16:50 -05:00
3 changed files with 17 additions and 6 deletions
@@ -163,7 +163,22 @@ else()
 endif()

 if(APPLE)
-    set_target_properties(${PROJECT_NAME} PROPERTIES MACOSX_BUNDLE TRUE)
+    # CFBundleIdentifier must not be empty. CMake's default Info.plist
+    # template fills it from MACOSX_BUNDLE_GUI_IDENTIFIER; with that unset
+    # the bundle ships an empty identifier, LaunchServices never registers
+    # the .app, and AppKit's open/save panel service (which is keyed on the
+    # client's bundle id) silently presents nothing -- every
+    # QFileDialog::getOpenFileName()/getSaveFileName() call returns an empty
+    # string without a panel ever appearing, so File > Open and File > Save
+    # as do nothing at all.
+    set_target_properties(${PROJECT_NAME} PROPERTIES
+        MACOSX_BUNDLE TRUE
+        MACOSX_BUNDLE_GUI_IDENTIFIER "org.qelectrotech.QElectroTech"
+        MACOSX_BUNDLE_BUNDLE_NAME "QElectroTech"
+        MACOSX_BUNDLE_BUNDLE_VERSION "${PROJECT_VERSION}"
+        MACOSX_BUNDLE_SHORT_VERSION_STRING "${PROJECT_VERSION}"
+        MACOSX_BUNDLE_COPYRIGHT "Copyright 2006-2026 The QElectroTech Team"
+    )
 endif()

 # The default build only compiles the tracked .ts files to .qm (lrelease).
@@ -42,7 +42,7 @@
 	<key>CFBundleIconFile</key>
 	<string>qelectrotech</string>
 	<key>CFBundleIdentifier</key>
-	<string>org.qelectrotech</string>
+	<string>org.qelectrotech.QElectroTech</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>
@@ -175,7 +175,6 @@ QET_LANG_DIR="${current_dir}/lang/"
 QET_EXAMPLES_DIR="${current_dir}/examples/"
 QET_FONTS_DIR="${current_dir}/fonts/"
 QET_LICENSES_DIR="${current_dir}/licenses/"
-LANG_DIR="${current_dir}/lang1/"

 if [ -d "${QET_ELMT_DIR}" ]; then
    cp -R ${QET_ELMT_DIR} $BUNDLE/Contents/Resources/elements
@@ -187,9 +186,6 @@ if [ -d "${QET_LANG_DIR}" ]; then
    mkdir $BUNDLE/Contents/Resources/lang
    cp ${current_dir}/lang/*.qm $BUNDLE/Contents/Resources/lang
 fi
-if [ -d "${LANG_DIR}" ]; then
-    cp ${current_dir}/lang1/*.qm $BUNDLE/Contents/Resources/lang
-fi
 if [ -d "${QET_EXAMPLES_DIR}" ]; then
    mkdir $BUNDLE/Contents/Resources/examples
    cp ${current_dir}/examples/*.qet $BUNDLE/Contents/Resources/examples
Author	SHA1	Message	Date
Laurent Trinques	957bbe5edb	macOS: drop obsolete lang1/ copy step lang1/ was a leftover from the pre-Qt6 translation pipeline. Qt6/CMake now produces all .qm files directly into lang/, which is already copied above, making this step dead code.	2026-09-09 16:02:02 +02:00
Laurent Trinques	ce0ba4a681	Merge pull request #829 from jp2images/fix-macos-bundle-identifier Set a bundle identifier so macOS file dialogs work	2026-09-09 15:57:21 +02:00
Laurent Trinques	8295083f05	misc: align macOS bundle identifier with app's settings domain CFBundleIdentifier was "org.qelectrotech", but Qt derives "org.qelectrotech.QElectroTech" from setOrganizationDomain() and setApplicationName() for the app's own preferences file (~/Library/Preferences/org.qelectrotech.QElectroTech.plist). Align the two so the shipped bundle and the CMake target (see CMakeLists.txt MACOSX_BUNDLE_GUI_IDENTIFIER) use the same identifier regardless of build path. Note: this changes the bundle's LaunchServices identity, so users may need to redo "Open With QElectroTech" file associations once after updating.	2026-09-09 15:54:28 +02:00
Jeff Patterson	a2441a6f81	Set a bundle identifier so macOS file dialogs work CMakeLists.txt marks the macOS target as MACOSX_BUNDLE but never sets MACOSX_BUNDLE_GUI_IDENTIFIER, so CMake's default Info.plist template substitutes an empty string for CFBundleIdentifier. An .app with an empty identifier is never registered by LaunchServices (`lsappinfo info` reports bundleID="" and bundle path=[NULL]). AppKit runs the open/save panel in an XPC service keyed on the client's bundle identifier: the service is spawned on each request but presents no window, so QFileDialog::getOpenFileName() and getSaveFileName() return an empty string without a panel ever appearing. In QET this means File > Open and File > Save as silently do nothing -- openProject() receives an empty path and returns at its `if (filepath.isEmpty())` guard. Every macOS CMake build has been affected since the target became a bundle. Fill in the identifier along with the other bundle metadata CMake's template expects. org.qelectrotech.QElectroTech is the identifier Qt already derives from setOrganizationDomain("qelectrotech.org") and setApplicationName("QElectroTech") for the app's own preferences file, so the bundle now agrees with what the app writes at runtime. Verified on macOS 27 with Qt 6.11: before the change File > Open and File > Save as present nothing; after it both panels open normally. No code signing step is needed -- the linker's ad-hoc signature still reports the executable name as its identifier, and the panels work regardless once the plist is correct.	2026-09-09 05:16:50 -05:00