// SPDX-License-Identifier: GPL-2.0-or-later #include #include #include #include #include #include #include #include "wiringrules.h" // The checks that drive QElectroTech through a script (--run) need a // build with scripting; without it --run is not an option and the // process never exits (QET_HAS_SCRIPTING, top-level CMakeLists.txt). #ifdef QET_HAS_SCRIPTING # define SKIP_WITHOUT_SCRIPTING #else # define SKIP_WITHOUT_SCRIPTING QSKIP("built without scripting: --run is not available") #endif // How many wires a terminal may take (discussion #1158). The rules are // tested on their own; the project setting and the refusal are tested // through the real binary: --resave keeps a element and // adds none to a project without it, and qet.addConductor() is refused // past the limit unless the master switch is off. class tst_wiringrules : public QObject { Q_OBJECT QTemporaryDir m_dir; int m_run = 0; // Environment of one sandboxed run; @p master_off writes the master // switch off into that run's own settings, @p application_max_wires // the limit every project follows unless it sets its own. QProcessEnvironment sandbox(bool master_off = false, int application_max_wires = 0) { const QString home = m_dir.filePath(QStringLiteral("home%1").arg(m_run)); const QString tmp = m_dir.filePath(QStringLiteral("tmp%1").arg(m_run)); const QString settings = m_dir.filePath(QStringLiteral("settings%1").arg(m_run)); ++m_run; QDir().mkpath(home); QDir().mkpath(tmp); QDir().mkpath(settings + QStringLiteral("/QElectroTech")); if (master_off || application_max_wires) { QFile ini(settings + QStringLiteral("/QElectroTech/QElectroTech.ini")); if (ini.open(QIODevice::WriteOnly | QIODevice::Text)) ini.write(QStringLiteral("[diagrameditor]\nwiring_rules_enabled=%1\nwiring_rules_max_wires=%2\n") .arg(master_off ? QStringLiteral("false") : QStringLiteral("true")) .arg(application_max_wires).toUtf8()); } QProcessEnvironment env = QProcessEnvironment::systemEnvironment(); env.insert(QStringLiteral("QT_QPA_PLATFORM"), QStringLiteral("offscreen")); env.insert(QStringLiteral("QET_ENABLE_SCRIPTING"), QStringLiteral("1")); env.insert(QStringLiteral("HOME"), home); env.insert(QStringLiteral("XDG_CONFIG_HOME"), home + QStringLiteral("/.config")); env.insert(QStringLiteral("XDG_DATA_HOME"), home + QStringLiteral("/.local/share")); env.insert(QStringLiteral("QET_SETTINGS_DIR"), settings); env.insert(QStringLiteral("TMPDIR"), tmp); return env; } // The fixture with @p rules inserted before , as a new file QString fixtureWith(const QString &rules) { QFile source(QFINDTESTDATA("fixtures/qet_bug_repro_resaved.qet")); if (!source.open(QIODevice::ReadOnly | QIODevice::Text)) return {}; QString text = QString::fromUtf8(source.readAll()); const int newdiagrams = text.indexOf(QLatin1String("= 0) return line.mid(i + mark.size()).trimmed(); } return {}; } private slots: void initTestCase() { QVERIFY(m_dir.isValid()); QVERIFY(QFile::exists(QStringLiteral(QET_TEST_BINARY_PATH))); } void limit() { WiringRules::Settings rules; QCOMPARE(WiringRules::limit(rules, true, false), 0); QCOMPARE(WiringRules::limit(rules, true, true), 0); rules.max_wires = 4; QCOMPARE(WiringRules::limit(rules, true, false), 4); QCOMPARE(WiringRules::limit(rules, true, true), 4); rules.one_wire_per_report = true; QCOMPARE(WiringRules::limit(rules, true, true), 1); QCOMPARE(WiringRules::limit(rules, true, false), 4); // The master switch turns every rule off QCOMPARE(WiringRules::limit(rules, false, false), 0); QCOMPARE(WiringRules::limit(rules, false, true), 0); } void hasRoom() { QVERIFY(WiringRules::hasRoom(0, 0)); QVERIFY(WiringRules::hasRoom(0, 19)); QVERIFY(WiringRules::hasRoom(2, 1)); QVERIFY(!WiringRules::hasRoom(2, 2)); QVERIFY(!WiringRules::hasRoom(2, 3)); QVERIFY(!WiringRules::hasRoom(1, 1)); } void projectOverridesApplication() { WiringRules::Settings application; application.max_wires = 2; application.one_wire_per_report = true; // A project that follows the application gets its rules WiringRules::Settings follows; QCOMPARE(WiringRules::effective(follows, application).max_wires, 2); QVERIFY(WiringRules::effective(follows, application).one_wire_per_report); QVERIFY(!WiringRules::effective(follows, application).own); // Its own rules win, "no limit" included WiringRules::Settings own; own.own = true; QCOMPARE(WiringRules::effective(own, application).max_wires, 0); QVERIFY(!WiringRules::effective(own, application).one_wire_per_report); QVERIFY(WiringRules::effective(own, application).own); own.max_wires = 6; QCOMPARE(WiringRules::effective(own, application).max_wires, 6); } void xmlRoundTrip() { QDomDocument doc; QDomElement root = doc.createElement(QStringLiteral("project")); doc.appendChild(root); // Following the application: nothing written, and reading // nothing follows the application WiringRules::Settings follows; follows.max_wires = 3; // not the project's: not written WiringRules::toXml(follows, root); QVERIFY(root.firstChildElement().isNull()); QVERIFY(WiringRules::fromXml(root).isDefault()); // Its own rules, even "none", are written and read back as its own WiringRules::Settings none; none.own = true; WiringRules::toXml(none, root); QCOMPARE(root.firstChildElement().tagName(), QStringLiteral("wiring_rules")); QVERIFY(WiringRules::fromXml(root) == none); root.removeChild(root.firstChildElement()); WiringRules::Settings rules; rules.own = true; rules.max_wires = 2; rules.one_wire_per_report = true; WiringRules::toXml(rules, root); QCOMPARE(root.firstChildElement().tagName(), QStringLiteral("wiring_rules")); QVERIFY(WiringRules::fromXml(root) == rules); } void savedSettingSurvivesResave() { const QString plain = resave(QFINDTESTDATA("fixtures/qet_bug_repro_resaved.qet")); QVERIFY2(!plain.isEmpty(), "--resave failed"); QVERIFY(!plain.contains(QLatin1String("wiring_rules"))); const QString with_rules = fixtureWith( QStringLiteral("")); QVERIFY(!with_rules.isEmpty()); const QString saved = resave(with_rules); QVERIFY2(!saved.isEmpty(), "--resave failed"); QVERIFY2(saved.contains(QLatin1String("max_wires_per_terminal=\"2\"")) && saved.contains(QLatin1String("one_wire_per_report=\"true\"")), "the setting was lost on save"); // A project's own "no rule" is kept too: it overrides the application's const QString own_none = fixtureWith(QStringLiteral("")); QVERIFY(!own_none.isEmpty()); const QString saved_none = resave(own_none); QVERIFY2(!saved_none.isEmpty(), "--resave failed"); QVERIFY2(saved_none.contains(QLatin1String("")), "a project's own rules were lost on save"); } void wirePastTheLimitIsRefused() { SKIP_WITHOUT_SCRIPTING; // Without a rule the wire is drawn, as on master QCOMPARE(addWireToWiredTerminal(QFINDTESTDATA("fixtures/qet_bug_repro_resaved.qet"), false), QStringLiteral("true")); // One wire per terminal: the terminal is full const QString limited = fixtureWith( QStringLiteral("")); QVERIFY(!limited.isEmpty()); QCOMPARE(addWireToWiredTerminal(limited, false), QStringLiteral("false")); // The master switch off: the project's rule does nothing QCOMPARE(addWireToWiredTerminal(limited, true), QStringLiteral("true")); // The application's limit applies to a project that sets none... const QString plain = QFINDTESTDATA("fixtures/qet_bug_repro_resaved.qet"); QCOMPARE(addWireToWiredTerminal(plain, false, 1), QStringLiteral("false")); // ...not to one that sets its own, here "no limit" const QString own_none = fixtureWith(QStringLiteral("")); QVERIFY(!own_none.isEmpty()); QCOMPARE(addWireToWiredTerminal(own_none, false, 1), QStringLiteral("true")); // ...and the master switch still turns it off QCOMPARE(addWireToWiredTerminal(plain, true, 1), QStringLiteral("true")); } }; QTEST_GUILESS_MAIN(tst_wiringrules) #include "tst_wiringrules.moc"