mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2026-10-09 21:54:13 +02:00
ispyisail
f5962ecd06
Every tr() source string in the code and the forms is now the English
text, and French is a translation (qet_fr.ts) like the other languages.
Generated, not hand-edited: master ef795a21e5 converted by
qet-en-source (harness 4c4ddc9).
3144 messages get an English source, 665 already had one, 0 left French; 8 shared-wording pairs disambiguated.
C++: 2904 literals in 233 files. Forms: 809 strings in 65 files. All 34 .ts files re-keyed; qet_fr.ts filled.
lupdate check: PASS. What each of 38 languages shows, old vs new: same 118266, English instead of French 38433, comment fallback 51, differences 0.
118 lines
4.2 KiB
C++
118 lines
4.2 KiB
C++
/*
|
|
Copyright 2006-2026 The QElectroTech Team
|
|
This file is part of QElectroTech.
|
|
|
|
QElectroTech is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
QElectroTech is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with QElectroTech. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#include "sqlreadonly.h"
|
|
|
|
#include <QCoreApplication>
|
|
#include <QSqlError>
|
|
|
|
namespace QETSql {
|
|
|
|
/**
|
|
@brief QETSql::execReadOnly
|
|
Run @p query on @p db with SQLite's query_only pragma set, so that
|
|
SQLite itself refuses anything that would write.
|
|
|
|
Why SQLite is asked rather than the text inspected: a check on the
|
|
query's first keyword cannot see what the statement actually does.
|
|
SQLite has allowed a CTE prefix in front of a data-modifying statement
|
|
since 3.8.3, so
|
|
|
|
@code
|
|
WITH x AS (SELECT 1) DELETE FROM element
|
|
@endcode
|
|
|
|
begins with WITH, contains no semicolon, and deletes every row. With
|
|
query_only set, SQLite fails that statement with SQLITE_READONLY when it
|
|
tries to start writing, before any row is touched, while an ordinary
|
|
WITH ... SELECT still runs.
|
|
|
|
Why a pragma rather than sqlite3_stmt_readonly(): that needs the
|
|
driver's native sqlite3 handle passed to the libsqlite3 QElectroTech
|
|
links. The QSQLITE plugin of the Qt online installer carries its own
|
|
private copy of SQLite, so that handle belongs to another library and
|
|
the call crashes (qelectrotech-source-mirror#1045). A pragma goes
|
|
through the driver, whichever SQLite it uses.
|
|
|
|
A statement that succeeded here is read-only, so running the returned
|
|
query again, as several callers do, runs a read-only statement again.
|
|
A refused one comes back as an empty query with nothing to run again:
|
|
query_only is only set for the duration of this call.
|
|
|
|
Qt's SQLite driver refuses a second statement after the first one, so
|
|
"SELECT 1; DROP TABLE element" is refused too.
|
|
|
|
This is a read-only test, NOT a statement-type allowlist: query_only
|
|
does not refuse ATTACH, BEGIN or most PRAGMAs, because none of them
|
|
change the contents of the database. Callers that need to restrict
|
|
which *kind* of statement is acceptable must say so separately --
|
|
projectDataBase::newQuery() keeps isReadOnlySelect() in front of this
|
|
for exactly that reason.
|
|
|
|
@param db the connection to run the query on
|
|
@param query the raw SQL text
|
|
@param error set to a human-readable reason when the query is refused
|
|
@return the executed query, or an empty query on @p db if @p query was
|
|
refused or failed
|
|
*/
|
|
QSqlQuery execReadOnly(const QSqlDatabase &db, const QString &query, QString *error)
|
|
{
|
|
if (error) {
|
|
error->clear();
|
|
}
|
|
|
|
if (!QSqlQuery(db).exec(QStringLiteral("PRAGMA query_only = ON"))) {
|
|
if (error) {
|
|
*error = QCoreApplication::translate("QETSql",
|
|
"Unable to verify the query: the database cannot be set to "
|
|
"read-only.");
|
|
}
|
|
return QSqlQuery(db);
|
|
}
|
|
|
|
QSqlQuery result(db);
|
|
const bool ok = result.exec(query);
|
|
//Switching query_only off aborts a statement SQLite is still
|
|
//stepping through -- an unsorted UNION ALL then ends after its
|
|
//first row. So the checked run is finished first, and a statement
|
|
//that passed is run again for the caller: SQLite refuses a write
|
|
//at its first step, so passing that step proves it read-only.
|
|
result.finish();
|
|
QSqlQuery(db).exec(QStringLiteral("PRAGMA query_only = OFF"));
|
|
|
|
if (ok) {
|
|
result.exec(query);
|
|
return result;
|
|
}
|
|
|
|
if (error) {
|
|
// SQLITE_READONLY is 8; extended codes keep it in the low byte.
|
|
if ((result.lastError().nativeErrorCode().toInt() & 0xff) == 8) {
|
|
*error = QCoreApplication::translate("QETSql",
|
|
"Only read-only queries are allowed: this query would "
|
|
"modify the database.");
|
|
} else {
|
|
*error = QCoreApplication::translate("QETSql",
|
|
"Invalid SQL query: %1")
|
|
.arg(result.lastError().databaseText());
|
|
}
|
|
}
|
|
return QSqlQuery(db);
|
|
}
|
|
|
|
} // namespace QETSql
|