kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-09-30 23:04:13 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
Files
44ed01ff5dab2c3822079c3190ade48495416dac
qelectrotech-source-mirror/sources
T
History
ispyisail 44ed01ff5d Don't let the wiring list lose a wire to the diagram join 
The comment above this view promised that it "returns exactly as many rows
as the conductor table holds", and argued carefully for the two joins that
could have broken that -- no inner join to element, and element_info LEFT
joined. Then it ended with an inner join to diagram that it never mentioned,
which can drop rows just as easily.

Feeding the real schema a conductor whose diagram_uuid has no diagram row
returned 2 view rows for 3 conductors. With the join made LEFT it returns 3,
with a null folio instead of a missing wire.

In practice this should never fire: QETProject::diagramAdded is connected to
addDiagram(), so the folio exists before anything can be drawn on it. But an
inner join turns that into an assumption the view enforces silently, and of
all the things this view can get wrong, dropping a wire from a wiring list
is the one that matters most. The comment now says which joins are inner and
why those two are safe.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-21 20:44:16 +12:00
..
autoNum
Merge pull request #588 from Kellermorph/Fix-PLC-Manager
2026-08-01 15:30:10 +02:00
dataBase
Don't let the wiring list lose a wire to the diagram join
2026-08-21 20:44:16 +12:00
diagramevent
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
dvevent
One year
2026-01-16 15:24:35 +01:00
dxf
dxf2elmt: point link to general release directory instead of special version
2026-01-26 18:47:43 +01:00
editor
Merge pull request #588 from Kellermorph/Fix-PLC-Manager
2026-08-01 15:30:10 +02:00
ElementsCollection
Apply the elements-panel light palette to the viewport too
2026-08-02 01:23:23 +12:00
factory
Merge pull request #582 from DieterMayerOSS/pr/font-legacy-format
2026-07-31 10:30:49 +02:00
import/edz
edz: make EdzArchive error strings translatable (+ DE/FR)
2026-07-26 21:04:25 +12:00
NameList
Fall back to the base language for element and folder names
2026-07-11 21:47:04 +02:00
print
Restore two more Qt5-only code paths on Qt6 (parts list, print dialog)
2026-07-28 13:58:32 +02:00
project
Add a local, per-project time-spent tracker (#576)
2026-07-31 09:52:32 +12:00
properties
Merge pull request #582 from DieterMayerOSS/pr/font-legacy-format
2026-07-31 10:30:49 +02:00
PropertiesEditor
One year
2026-01-16 15:24:35 +01:00
qet_elementscaler
use "%" for string-concatenation
2025-05-22 21:33:32 +02:00
qetgraphicsitem
Give every terminal an identity, not only uuid-aware ones
2026-08-21 20:42:21 +12:00
QetGraphicsItemModeler
One year
2026-01-16 15:24:35 +01:00
QPropertyUndoCommand
One year
2026-01-16 15:24:35 +01:00
QWidgetAnimation
One year
2026-01-16 15:24:35 +01:00
richtext
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
SearchAndReplace
Replace hash.keys().contains(k) with hash.contains(k) (35 call sites)
2026-07-28 13:58:33 +02:00
svg
One year
2026-01-16 15:24:35 +01:00
TerminalStrip
terminalstripdrawer.cpp: fix two Qt6 compile errors
2026-07-17 10:26:43 +02:00
titleblock
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
ui
Merge pull request #588 from Kellermorph/Fix-PLC-Manager
2026-08-01 15:30:10 +02:00
undocommand
Merge pull request #588 from Kellermorph/Fix-PLC-Manager
2026-08-01 15:30:10 +02:00
utils
Merge pull request #592 from DieterMayerOSS/pr/font-report
2026-08-01 11:41:55 +02:00
xml
One year
2026-01-16 15:24:35 +01:00
borderproperties.cpp
One year
2026-01-16 15:24:35 +01:00
borderproperties.h
One year
2026-01-16 15:24:35 +01:00
bordertitleblock.cpp
Fix #531: page-level empty title block variable no longer shadows project-level value
2026-07-30 18:32:54 +12:00
bordertitleblock.h
One year
2026-01-16 15:24:35 +01:00
cli_export.cpp
Guard Qt6-only deprecation replacements for Qt5 compatibility
2026-07-14 19:27:18 +02:00
cli_export.h
CLI: add --set-titleblock to stamp title-block fields headlessly
2026-06-12 05:25:44 +12:00
conductorautonumerotation.cpp
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
conductorautonumerotation.h
One year
2026-01-16 15:24:35 +01:00
conductornumexport.cpp
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
conductornumexport.h
One year
2026-01-16 15:24:35 +01:00
conductorprofile.cpp
One year
2026-01-16 15:24:35 +01:00
conductorprofile.h
One year
2026-01-16 15:24:35 +01:00
conductorproperties.cpp
One year
2026-01-16 15:24:35 +01:00
conductorproperties.h
One year
2026-01-16 15:24:35 +01:00
conductorsegment.cpp
One year
2026-01-16 15:24:35 +01:00
conductorsegment.h
One year
2026-01-16 15:24:35 +01:00
conductorsegmentprofile.h
One year
2026-01-16 15:24:35 +01:00
configdialog.cpp
One year
2026-01-16 15:24:35 +01:00
configdialog.h
One year
2026-01-16 15:24:35 +01:00
createdxf.cpp
One year
2026-01-16 15:24:35 +01:00
createdxf.h
One year
2026-01-16 15:24:35 +01:00
diagram.cpp
Add terminal and conductor tables to projectDataBase
2026-08-21 19:07:49 +12:00
diagram.h
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
diagramcommands.cpp
Give Conductor its own persisted uuid
2026-08-02 08:12:22 +12:00
diagramcommands.h
One year
2026-01-16 15:24:35 +01:00
diagramcontent.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
diagramcontent.h
One year
2026-01-16 15:24:35 +01:00
diagramcontext.cpp
One year
2026-01-16 15:24:35 +01:00
diagramcontext.h
One year
2026-01-16 15:24:35 +01:00
diagramposition.cpp
One year
2026-01-16 15:24:35 +01:00
diagramposition.h
One year
2026-01-16 15:24:35 +01:00
diagramview.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
diagramview.h
makro
2026-04-26 10:48:47 +02:00
elementdialog.cpp
Element editor Save As: label the field as a file name, not element name (#469)
2026-06-12 05:34:20 +12:00
elementdialog.h
makro
2026-04-26 10:48:47 +02:00
elementprovider.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
elementprovider.h
One year
2026-01-16 15:24:35 +01:00
elementscategoryeditor.cpp
One year
2026-01-16 15:24:35 +01:00
elementscategoryeditor.h
One year
2026-01-16 15:24:35 +01:00
elementscollectioncache.cpp
Wrap deprecated QSqlDatabase::exec() in QSqlQuery
2026-07-14 19:27:17 +02:00
elementscollectioncache.h
One year
2026-01-16 15:24:35 +01:00
elementsmover.cpp
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
elementsmover.h
One year
2026-01-16 15:24:35 +01:00
elementspanel.cpp
Apply the elements-panel light palette to the viewport too
2026-08-02 01:23:23 +12:00
elementspanel.h
Fix and Improve Multi-selection for Diagram Operations
2026-05-13 19:42:11 +02:00
elementspanelwidget.cpp
Regenerate conductor uuids when a folio is duplicated
2026-08-21 19:07:40 +12:00
elementspanelwidget.h
Feat: Add ability to duplicate diagrams/folios with all metadata and elements
2026-05-29 19:14:36 +02:00
elementtextpattern.cpp
One year
2026-01-16 15:24:35 +01:00
elementtextpattern.h
One year
2026-01-16 15:24:35 +01:00
elementtextsmover.cpp
One year
2026-01-16 15:24:35 +01:00
elementtextsmover.h
One year
2026-01-16 15:24:35 +01:00
exportdialog.cpp
Fix four memory leaks found by AddressSanitizer
2026-06-21 01:45:07 +12:00
exportdialog.h
One year
2026-01-16 15:24:35 +01:00
exportproperties.cpp
Address review feedback: double spinboxes, tabs, and fix export bug
2026-06-18 13:37:24 +02:00
exportproperties.h
Address review feedback: double spinboxes, tabs, and fix export bug
2026-06-18 13:37:24 +02:00
exportpropertieswidget.cpp
One year
2026-01-16 15:24:35 +01:00
exportpropertieswidget.h
One year
2026-01-16 15:24:35 +01:00
genericpanel.cpp
Fix four memory leaks found by AddressSanitizer
2026-06-21 01:45:07 +12:00
genericpanel.h
Fix losing Focus on moving diagram position with keyboard
2026-04-19 10:44:52 +02:00
machine_info.cpp
Fix remaining Qt6 build errors after PR #540
2026-07-17 10:25:49 +02:00
machine_info.h
Fix three uninitialised-value bugs found by Valgrind
2026-06-20 22:31:06 +12:00
main.cpp
Merge pull request #563 from DieterMayerOSS/pr/log-handler-before-startup
2026-07-28 17:35:11 +02:00
newelementwizard.cpp
One year
2026-01-16 15:24:35 +01:00
newelementwizard.h
One year
2026-01-16 15:24:35 +01:00
pdf_links.cpp
PDF links: extract pdf_links.{cpp,h} shared helper
2026-06-11 23:48:14 +12:00
pdf_links.h
PDF links: extract pdf_links.{cpp,h} shared helper
2026-06-11 23:48:14 +12:00
projectview.cpp
Add undo/redo support for folio add, delete, and reorder (#575)
2026-08-01 17:03:39 +12:00
projectview.h
Add undo/redo support for folio add, delete, and reorder (#575)
2026-08-01 17:03:39 +12:00
qet.cpp
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
qet.h
One year
2026-01-16 15:24:35 +01:00
qetapp.cpp
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
qetapp.h
macOS: fix QFileOpenEvent routing for .qet/.elmt/.titleblock double-click
2026-06-21 12:10:13 +02:00
qetarguments.cpp
One year
2026-01-16 15:24:35 +01:00
qetarguments.h
One year
2026-01-16 15:24:35 +01:00
qetdiagrameditor.cpp
Merge pull request #592 from DieterMayerOSS/pr/font-report
2026-08-01 11:41:55 +02:00
qetdiagrameditor.h
Add Ctrl+G "jump to element" type-ahead popup (#574)
2026-08-01 01:05:43 +12:00
qeticons.cpp
Add Korean switch language
2026-02-02 14:44:10 +01:00
qeticons.h
Add Korean switch language
2026-02-02 14:44:10 +01:00
qetinformation.cpp
PLC Manager
2026-07-27 22:16:52 +02:00
qetinformation.h
Fix-PLC-Manager
2026-07-31 21:02:07 +02:00
qetmainwindow.cpp
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
qetmainwindow.h
One year
2026-01-16 15:24:35 +01:00
qetmessagebox.cpp
One year
2026-01-16 15:24:35 +01:00
qetmessagebox.h
One year
2026-01-16 15:24:35 +01:00
qetproject.cpp
Add undo/redo support for folio add, delete, and reorder (#575)
2026-08-01 17:03:39 +12:00
qetproject.h
Add undo/redo support for folio add, delete, and reorder (#575)
2026-08-01 17:03:39 +12:00
qetregexpvalidator.cpp
One year
2026-01-16 15:24:35 +01:00
qetregexpvalidator.h
One year
2026-01-16 15:24:35 +01:00
qetresult.cpp
One year
2026-01-16 15:24:35 +01:00
qetresult.h
One year
2026-01-16 15:24:35 +01:00
qetversion.cpp
Revert "Set QET version to 0.200.1 when built with Qt6"
2026-07-19 13:26:34 +02:00
qetversion.h
One year
2026-01-16 15:24:35 +01:00
qetxml.cpp
Salvage font descriptions written by Qt 6.11+ when parsing fails
2026-07-31 08:10:34 +02:00
qetxml.h
Fix remaining Qt6 build errors after PR #540
2026-07-17 10:25:49 +02:00
qfilenameedit.cpp
One year
2026-01-16 15:24:35 +01:00
qfilenameedit.h
One year
2026-01-16 15:24:35 +01:00
qgimanager.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
qgimanager.h
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
qtextorientationspinboxwidget.cpp
One year
2026-01-16 15:24:35 +01:00
qtextorientationspinboxwidget.h
One year
2026-01-16 15:24:35 +01:00
qtextorientationwidget.cpp
One year
2026-01-16 15:24:35 +01:00
qtextorientationwidget.h
One year
2026-01-16 15:24:35 +01:00
recentfiles.cpp
Fix : can't open recent file
2026-07-17 10:29:13 +02:00
recentfiles.h
Fix : can't open recent file
2026-07-17 10:29:13 +02:00
shortcutmanager.cpp
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
shortcutmanager.h
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
titleblockcell.cpp
Wrap code for better readability
2020-09-07 22:03:40 +02:00
titleblockcell.h
One year
2026-01-16 15:24:35 +01:00
titleblockproperties.cpp
One year
2026-01-16 15:24:35 +01:00
titleblockproperties.h
One year
2026-01-16 15:24:35 +01:00
titleblocktemplate.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
titleblocktemplate.h
One year
2026-01-16 15:24:35 +01:00
titleblocktemplaterenderer.cpp
Wrap code for better readability
2020-09-07 22:03:40 +02:00
titleblocktemplaterenderer.h
One year
2026-01-16 15:24:35 +01:00
wiringlistexport.cpp
CLI export: add wiring list and wire-number list (CSV)
2026-06-11 12:39:43 +12:00
wiringlistexport.h
CLI export: add wiring list and wire-number list (CSV)
2026-06-11 12:39:43 +12:00