ispyisail 799ff5573f Revert the isFull() change: max_slaves counts slots, not contacts ...

The earlier commit changed MasterElement::isFull() to compare the
contacts in use against max_slaves. That was wrong, and this restores
the original comparison against the number of linked elements.

max_slaves is a number of slots, not of contacts:

 - it sizes the contact group table in the element editor, one row per
   slot (ElementPropertiesEditorWidget::populateSlaveGroupsTable)
 - a group must match the slave's own contact count before it can be
   chosen, so a 4 pole slave needs a group declaring 4 and occupies
   that single group (ContactGroupSelectionDialog)
 - each slave stores exactly one group index
   (Element::setGroupIndexForElement)

So a coil declaring 4 slots accepts 4 slaves, whatever their pole
count. Counting contacts made one 4 pole slave fill a 4 slot coil on
its own and refuse three further links that should have been allowed.

ContactUsage stays, and its per-type tally is still what the General
tab needs: how many contacts an auxiliary block must provide is a
different question from how many slots are occupied, and only the
former wants the pole multiplier. The header now says so.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-09-09 11:45:36 +12:00

..

autoNum

fix(ui): remove legacy Qt5 font weight tags in autonumberingmanagementw.ui

2026-08-29 11:02:59 +02:00

dataBase

Merge pull request #787 from ispyisail/fix/removediagram-cascade-delete

2026-09-07 10:05:27 +02:00

diagramevent

Add editable resize/rotate/skew handles for shapes and images

2026-09-05 15:48:28 +02:00

dvevent

One year

2026-01-16 15:24:35 +01:00

dxf

dxf2elmt: point link to general release directory instead of special version

2026-01-26 18:47:43 +01:00

editor

Merge pull request #688 from IBSYSLevi/fix/saving-coil-master

2026-09-08 08:35:00 +02:00

ElementsCollection

Fix crash when expanding templates/macros tree (Qt6 regression)

2026-08-27 07:27:25 +02:00

factory

Merge pull request #744 from ispyisail/fix/bugtracker-335-dark-theme-collection-icons

2026-08-14 10:02:39 +02:00

import/edz

fix deprecation-warning about "setContent" with qt >= 6.5

2026-08-17 10:25:44 +02:00

logging

Add an event-loop responsiveness watchdog (discussion #644 follow-up)

2026-08-06 23:05:05 +12:00

NameList

Fall back to the base language for element and folder names

2026-07-11 21:47:04 +02:00

print

FIX compile-warnings

2026-08-22 13:34:29 +02:00

project

Add a local, per-project time-spent tracker (#576)

2026-07-31 09:52:32 +12:00

properties

Merge pull request #771 from Kellermorph/spinbox-crossref

2026-09-08 08:20:33 +02:00

PropertiesEditor

Fix bugtracker #275: element properties window stuck centered on macOS

2026-08-11 11:48:58 +12:00

qet_elementscaler

use "%" for string-concatenation

2025-05-22 21:33:32 +02:00

qetgraphicsitem

Revert the isFull() change: max_slaves counts slots, not contacts

2026-09-09 11:45:36 +12:00

QetGraphicsItemModeler

One year

2026-01-16 15:24:35 +01:00

QPropertyUndoCommand

Fixing undo operations of graphs and images. Changing undo names.

2026-09-07 10:44:30 +02:00

QWidgetAnimation

One year

2026-01-16 15:24:35 +01:00

richtext

FIX compile-warnings

2026-08-22 13:34:29 +02:00

SearchAndReplace

Scroll the diagram view to the selected search hit

2026-08-10 21:19:56 +12:00

svg

One year

2026-01-16 15:24:35 +01:00

TerminalStrip

remove #include that's already in own header-file

2026-08-17 16:46:49 +02:00

titleblock

Clean up readSettingsState() in all three editors

2026-08-23 18:25:23 +02:00

ui

Fix Qt5 build: QLabel::pixmap() returns a pointer, not a value

2026-09-09 09:52:06 +12:00

undocommand

Add editable resize/rotate/skew handles for shapes and images

2026-09-05 15:48:28 +02:00

utils

Remove all Qt version checks and branches for <5.14.0 as such versions are no longer supported.

2026-08-13 15:45:15 +02:00

xml

One year

2026-01-16 15:24:35 +01:00

autobreakconductor.cpp

autoBreakConductors: share conductors_handled/used_terminals across batch

2026-08-09 09:11:40 +02:00

autobreakconductor.h

autoBreakConductors: share conductors_handled/used_terminals across batch

2026-08-09 09:11:40 +02:00

borderproperties.cpp

One year

2026-01-16 15:24:35 +01:00

borderproperties.h

One year

2026-01-16 15:24:35 +01:00

bordertitleblock.cpp

Fix #531: page-level empty title block variable no longer shadows project-level value

2026-07-30 18:32:54 +12:00

bordertitleblock.h

Change comment style for title block edge method

2026-08-13 08:50:24 +08:00

cli_export.cpp

CLI export: add --show-terminals instead of hardcoding markers off

2026-08-12 10:33:37 -06:00

cli_export.h

CLI export: document --show-terminals in cli_export.h

2026-08-12 10:33:45 -06:00

conductorautonumerotation.cpp

Cover auto-numbering counter changes with undo/redo

2026-08-03 13:19:51 +12:00

conductorautonumerotation.h

One year

2026-01-16 15:24:35 +01:00

conductornumexport.cpp

Remove all Qt version checks and branches for <5.15.12 as such versions are no longer supported.

2026-08-13 16:20:30 +02:00

conductornumexport.h

One year

2026-01-16 15:24:35 +01:00

conductorprofile.cpp

One year

2026-01-16 15:24:35 +01:00

conductorprofile.h

One year

2026-01-16 15:24:35 +01:00

conductorproperties.cpp

Remove all Qt version checks and branches for <5.14.0 as such versions are no longer supported.

2026-08-13 15:45:15 +02:00

conductorproperties.h

One year

2026-01-16 15:24:35 +01:00

conductorsegment.cpp

One year

2026-01-16 15:24:35 +01:00

conductorsegment.h

One year

2026-01-16 15:24:35 +01:00

conductorsegmentprofile.h

One year

2026-01-16 15:24:35 +01:00

configdialog.cpp

Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.

2026-08-08 00:32:31 +02:00

configdialog.h

One year

2026-01-16 15:24:35 +01:00

contactusage.h

Revert the isFull() change: max_slaves counts slots, not contacts

2026-09-09 11:45:36 +12:00

createdxf.cpp

One year

2026-01-16 15:24:35 +01:00

createdxf.h

One year

2026-01-16 15:24:35 +01:00

diagram.cpp

Add a unit test locking in Diagram::toXml()'s coordinate sort order

2026-09-07 20:54:18 +12:00

diagram.h

fix whitespace

2026-08-07 13:48:40 +02:00

diagramcommands.cpp

Merge pull request #770 from Kellermorph/copy-fix

2026-08-23 11:07:31 +02:00

diagramcommands.h

Fix paste breaking existing conductors

2026-08-22 11:25:47 +02:00

diagramcontent.cpp

Replace deprecated qAsConst with std::as_const

2026-07-14 19:27:16 +02:00

diagramcontent.h

One year

2026-01-16 15:24:35 +01:00

diagramcontext.cpp

One year

2026-01-16 15:24:35 +01:00

diagramcontext.h

One year

2026-01-16 15:24:35 +01:00

diagramposition.cpp

One year

2026-01-16 15:24:35 +01:00

diagramposition.h

One year

2026-01-16 15:24:35 +01:00

diagramsortkeys.h

Add a unit test locking in Diagram::toXml()'s coordinate sort order

2026-09-07 20:54:18 +12:00

diagramview.cpp

Apply the same zoom clamp to DiagramView::zoom()

2026-08-31 05:47:04 +12:00

diagramview.h

Apply the same zoom clamp to DiagramView::zoom()

2026-08-31 05:47:04 +12:00

dxfpaintdevice.cpp

Connected to previous image handling updates: images were not exported at all to dxf. In this

2026-09-07 10:44:30 +02:00

dxfpaintdevice.h

Connected to previous image handling updates: images were not exported at all to dxf. In this

2026-09-07 10:44:30 +02:00

elementdialog.cpp

Fix invisible element icons on dark themes in Open/Save Element and New Element Wizard dialogs

2026-08-08 21:53:20 +12:00

elementdialog.h

makro

2026-04-26 10:48:47 +02:00

elementprovider.cpp

Replace deprecated qAsConst with std::as_const

2026-07-14 19:27:16 +02:00

elementprovider.h

One year

2026-01-16 15:24:35 +01:00

elementscategoryeditor.cpp

Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.

2026-08-08 00:32:31 +02:00

elementscategoryeditor.h

One year

2026-01-16 15:24:35 +01:00

elementscollectioncache.cpp

Wrap deprecated QSqlDatabase::exec() in QSqlQuery

2026-07-14 19:27:17 +02:00

elementscollectioncache.h

One year

2026-01-16 15:24:35 +01:00

elementsmover.cpp

autoBreakConductors: share conductors_handled/used_terminals across batch

2026-08-09 09:11:40 +02:00

elementsmover.h

One year

2026-01-16 15:24:35 +01:00

elementspanel.cpp

Remaining signal/slot migration and clean-up after the latest merge.

2026-08-09 11:51:23 +02:00

elementspanel.h

Fix and Improve Multi-selection for Diagram Operations

2026-05-13 19:42:11 +02:00

elementspanelwidget.cpp

Merge pull request #628 from ispyisail/feature-wiring-db-tables

2026-08-21 14:03:02 +02:00

elementspanelwidget.h

Add "Insert folio above/below" to the elements panel's folio menu

2026-08-04 16:36:23 +12:00

elementtextpattern.cpp

One year

2026-01-16 15:24:35 +01:00

elementtextpattern.h

One year

2026-01-16 15:24:35 +01:00

elementtextsmover.cpp

One year

2026-01-16 15:24:35 +01:00

elementtextsmover.h

One year

2026-01-16 15:24:35 +01:00

exportdialog.cpp

Connected to previous image handling updates: images were not exported at all to dxf. In this

2026-09-07 10:44:30 +02:00

exportdialog.h

One year

2026-01-16 15:24:35 +01:00

exportproperties.cpp

set to false

2026-08-08 08:09:45 +02:00

exportproperties.h

new Checkbox

2026-08-06 21:37:40 +02:00

exportpropertieswidget.cpp

Re-adding connects (migrated) which got lost unfortunately during the migration and repeated merging.

2026-08-09 19:25:56 +02:00

exportpropertieswidget.h

new Checkbox

2026-08-06 21:37:40 +02:00

genericpanel.cpp

fix

2026-09-03 15:05:22 +02:00

genericpanel.h

Fix losing Focus on moving diagram position with keyboard

2026-04-19 10:44:52 +02:00

lastusedstyle.cpp

Remember last-used shape/text style for new items this session

2026-08-04 10:32:25 +12:00

lastusedstyle.h

Remember last-used shape/text style for new items this session

2026-08-04 10:32:25 +12:00

machine_info.cpp

Fix remaining Qt6 build errors after PR #540

2026-07-17 10:25:49 +02:00

machine_info.h

Fix three uninitialised-value bugs found by Valgrind

2026-06-20 22:31:06 +12:00

main.cpp

Remove all Qt version checks and branches for <5.14.0 as such versions are no longer supported.

2026-08-13 15:45:15 +02:00

newelementwizard.cpp

Fix bugtracker #281: new-part wizard's element editor opens behind main window

2026-08-11 11:33:28 +12:00

newelementwizard.h

One year

2026-01-16 15:24:35 +01:00

pdf_links.cpp

fix problem with PDF-links in files with brackets in name

2026-08-24 18:24:30 +02:00

pdf_links.h

fix

2026-08-14 08:58:36 +02:00

projectview.cpp

Fix: avoid crash when opening a project without a folio (diagram).

2026-08-28 19:55:29 +02:00

projectview.h

Fixing MacOS only GUI adjustment relying on QWheelEvent->delta() which was removed in Qt6. Some simplification was possible but no test due to lack of OS.

2026-08-12 12:29:56 +02:00

qet.cpp

Fixing undo operations of graphs and images. Changing undo names.

2026-09-07 10:44:30 +02:00

qet.h

One year

2026-01-16 15:24:35 +01:00

qetapp.cpp

adjust whitespace

2026-09-05 00:22:35 +02:00

qetapp.h

Add crash-time ring flush and a diagnostics export UI (discussion #644, steps 4-5)

2026-08-06 23:04:27 +12:00

qetarguments.cpp

One year

2026-01-16 15:24:35 +01:00

qetarguments.h

One year

2026-01-16 15:24:35 +01:00

qetdiagrameditor.cpp

Add editable resize/rotate/skew handles for shapes and images

2026-09-05 15:48:28 +02:00

qetdiagrameditor.h

Fix dock widget size/position not being restored on Qt6

2026-08-22 11:08:02 +02:00

qeticons.cpp

Adding icons to graphs and image operations.

2026-09-07 10:44:30 +02:00

qeticons.h

Adding icons to graphs and image operations.

2026-09-07 10:44:30 +02:00

qetinformation.cpp

Add 'Text field' option for slave cross-reference positioning

2026-09-05 18:55:14 +02:00

qetinformation.h

Add 'Text field' option for slave cross-reference positioning

2026-09-05 18:55:14 +02:00

qetmainwindow.cpp

move "diagnostics_action_" upwards in help-menu

2026-08-11 14:11:00 +02:00

qetmainwindow.h

Add crash-time ring flush and a diagnostics export UI (discussion #644, steps 4-5)

2026-08-06 23:04:27 +12:00

qetmessagebox.cpp

One year

2026-01-16 15:24:35 +01:00

qetmessagebox.h

One year

2026-01-16 15:24:35 +01:00

qetproject.cpp

Fix segfault when a project is destroyed with a diagram still pending deleteLater()

2026-08-25 06:59:02 +12:00

qetproject.h

In order to migrate to Qt6 all options for KF6 were added:

2026-08-12 12:29:56 +02:00

qetregexpvalidator.cpp

One year

2026-01-16 15:24:35 +01:00

qetregexpvalidator.h

One year

2026-01-16 15:24:35 +01:00

qetresult.cpp

One year

2026-01-16 15:24:35 +01:00

qetresult.h

One year

2026-01-16 15:24:35 +01:00

qetversion.cpp

Update QVersionNumber to 0, 200, 1

2026-08-16 07:16:33 +02:00

qetversion.h

One year

2026-01-16 15:24:35 +01:00

qetxml.cpp

Salvage font descriptions written by Qt 6.11+ when parsing fails

2026-07-31 08:10:34 +02:00

qetxml.h

Fix remaining Qt6 build errors after PR #540

2026-07-17 10:25:49 +02:00

qfilenameedit.cpp

Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.

2026-08-08 00:32:31 +02:00

qfilenameedit.h

One year

2026-01-16 15:24:35 +01:00

qgimanager.cpp

Fix the remaining Qt6 compile blockers

2026-07-17 21:01:26 +02:00

qgimanager.h

Fix the remaining Qt6 compile blockers

2026-07-17 21:01:26 +02:00

qtextorientationspinboxwidget.cpp

Migration of signal/slot to method pointer continued. Mostly simple cases.

2026-08-09 01:34:22 +02:00

qtextorientationspinboxwidget.h

One year

2026-01-16 15:24:35 +01:00

qtextorientationwidget.cpp

One year

2026-01-16 15:24:35 +01:00

qtextorientationwidget.h

One year

2026-01-16 15:24:35 +01:00

recentfiles.cpp

Fix : can't open recent file

2026-07-17 10:29:13 +02:00

recentfiles.h

Fix : can't open recent file

2026-07-17 10:29:13 +02:00

shortcutmanager.cpp

Replacing depreciated qAsConst with std::as_const

2026-08-12 12:29:56 +02:00

shortcutmanager.h

Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)

2026-08-01 01:35:51 +12:00

titleblockcell.cpp

Wrap code for better readability

2020-09-07 22:03:40 +02:00

titleblockcell.h

One year

2026-01-16 15:24:35 +01:00

titleblockproperties.cpp

One year

2026-01-16 15:24:35 +01:00

titleblockproperties.h

One year

2026-01-16 15:24:35 +01:00

titleblocktemplate.cpp

Remove all Qt version checks and branches for <5.14.0 as such versions are no longer supported.

2026-08-13 15:45:15 +02:00

titleblocktemplate.h

TitleBlockTemplate::minimumWidth() divided by (100.0 - sum(RelativeToTotalLength)) without guarding against a zero or negative denominator. When a template's relative-to-total-length

2026-08-08 12:31:45 +02:00

titleblocktemplaterenderer.cpp

Wrap code for better readability

2020-09-07 22:03:40 +02:00

titleblocktemplaterenderer.h

One year

2026-01-16 15:24:35 +01:00

wiringlistexport.cpp

CLI export: add wiring list and wire-number list (CSV)

2026-06-11 12:39:43 +12:00

wiringlistexport.h

CLI export: add wiring list and wire-number list (CSV)

2026-06-11 12:39:43 +12:00