mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2026-10-08 21:14:14 +02:00
Beat Hangartner
863c5e07ba
TitleBlockTemplateLogoManager never sets read_only_: its constructor leaves the member uninitialised, and setReadOnly() returns early when the new value equals the member. The template editor calls setReadOnly() right after creating the manager, so whenever the garbage value happened to match, the call did nothing: the add, delete and rename buttons stayed enabled on a read-only template, and isReadOnly() returned garbage. Give the member a default value, false, in the header, matching the buttons' state after construction. Only sources/titleblock/templatelogomanager.h changes. No behaviour change for an editable template: setReadOnly(false) on a manager that is already editable still returns early. No file-format change. Tests: none of their own; an uninitialised read is what a sanitizer finds, and this one is the same kind as the BorderTitleBlock and ConductorProfile fixes (#1358, #1359). ctest on macOS, and all example projects through --resave and --export-svg, unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Beat Hangartner <beat@hangartners.ch>