mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2026-10-08 21:14:14 +02:00
Beat Hangartner
7933e89dc0
ConductorProperties::toSettings() writes the conductor width with QString::number(cond_size), e.g. "1.4", and fromSettings() read it back with toInt(), which is 0 for any value that is not a whole number. A default width of 1.4 set in the configuration became 0 on the next start, so every new conductor was drawn with a pen of width 0. Read it with toDouble(), and fall back to 1 when the stored value is not a positive finite number (a hand-edited or truncated settings file), as the other fallbacks in fromSettings() do. No file-format change: this is the settings file only; the project file's condsize attribute was already read with toDouble(). Tests: tst_conductorsizesetting compiles conductorproperties.cpp alone and round-trips 2, 1.4, 0.4, 61.3 and 61.7 through toSettings() and fromSettings() in a QSettings scope of its own; text, 0, -1, nan, inf and a missing value give 1. Nine of the cases fail on master. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Beat Hangartner <beat@hangartners.ch>
114 lines
3.3 KiB
C++
114 lines
3.3 KiB
C++
/*
|
|
Copyright 2006-2026 The QElectroTech Team
|
|
This file is part of QElectroTech.
|
|
|
|
QElectroTech is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
QElectroTech is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with QElectroTech. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#include "conductorproperties.h"
|
|
#include "qetapp.h"
|
|
|
|
#include <QtTest>
|
|
#include <QSettings>
|
|
|
|
// qet.cpp, compiled in for ConductorProperties, refers to this static.
|
|
QString QETApp::m_interface_language;
|
|
|
|
/**
|
|
ConductorProperties::toSettings()/fromSettings() keep the conductor
|
|
width (cond_size) as it was saved. The width is a decimal, written with
|
|
QString::number(); reading it with toInt() gave 0 for every value that
|
|
was not a whole number, so a default width of 1.4 came back as 0 after
|
|
a restart.
|
|
|
|
This test owns its own QSettings scope (organization + application
|
|
name), so it cannot read or write the configuration of whoever runs it.
|
|
*/
|
|
class tst_conductorsizesetting : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void initTestCase()
|
|
{
|
|
QCoreApplication::setOrganizationName(
|
|
QStringLiteral("QElectroTech-tst_conductorsizesetting"));
|
|
QCoreApplication::setApplicationName(QStringLiteral("tst_conductorsizesetting"));
|
|
QSettings settings;
|
|
settings.clear();
|
|
}
|
|
|
|
void init()
|
|
{
|
|
QSettings settings;
|
|
settings.clear();
|
|
settings.sync();
|
|
}
|
|
|
|
void widthSurvivesARoundTrip_data()
|
|
{
|
|
QTest::addColumn<qreal>("width");
|
|
QTest::newRow("whole number") << 2.0;
|
|
QTest::newRow("decimal") << 1.4;
|
|
QTest::newRow("minimum") << 0.4;
|
|
QTest::newRow("rounds down") << 61.3;
|
|
QTest::newRow("rounds up") << 61.7;
|
|
}
|
|
|
|
void widthSurvivesARoundTrip()
|
|
{
|
|
QFETCH(qreal, width);
|
|
QSettings settings;
|
|
ConductorProperties saved;
|
|
saved.cond_size = width;
|
|
saved.toSettings(settings, QStringLiteral("test/"));
|
|
|
|
ConductorProperties loaded;
|
|
loaded.fromSettings(settings, QStringLiteral("test/"));
|
|
QCOMPARE(loaded.cond_size, width);
|
|
}
|
|
|
|
// A hand-edited or truncated settings file must not give a width of 0.
|
|
void unusableValueFallsBackToOne_data()
|
|
{
|
|
QTest::addColumn<QString>("value");
|
|
QTest::newRow("text") << QStringLiteral("wide");
|
|
QTest::newRow("zero") << QStringLiteral("0");
|
|
QTest::newRow("negative") << QStringLiteral("-1");
|
|
QTest::newRow("nan") << QStringLiteral("nan");
|
|
QTest::newRow("inf") << QStringLiteral("inf");
|
|
}
|
|
|
|
void unusableValueFallsBackToOne()
|
|
{
|
|
QFETCH(QString, value);
|
|
QSettings settings;
|
|
settings.setValue(QStringLiteral("test/size"), value);
|
|
|
|
ConductorProperties loaded;
|
|
loaded.fromSettings(settings, QStringLiteral("test/"));
|
|
QCOMPARE(loaded.cond_size, 1.0);
|
|
}
|
|
|
|
void missingValueIsOne()
|
|
{
|
|
QSettings settings;
|
|
ConductorProperties loaded;
|
|
loaded.fromSettings(settings, QStringLiteral("test/"));
|
|
QCOMPARE(loaded.cond_size, 1.0);
|
|
}
|
|
};
|
|
|
|
QTEST_GUILESS_MAIN(tst_conductorsizesetting)
|
|
#include "tst_conductorsizesetting.moc"
|