Beat Hangartner ad14eb1724 Delete the text items ElementPictureFactory::build() creates and drops ...

parseText() creates a QGraphicsSimpleTextItem for every <text> of an
element (the DXF export reads them later) and appends it to the
primitives it is given. build() draws every primitive twice, once for
the normal and once for the low-zoom picture, and gave the second pass
a fresh `primitives fake_prim` per primitive that went out of scope
with its text items still allocated. dropCache() also removed a
location's primitives without deleting their text items.

LeakSanitizer on the Linux CI sanitizer build (separate PR) stops
every --resave or export of a project whose elements have texts:

  ERROR: LeakSanitizer: detected memory leaks
  Indirect leak of 37200 byte(s) in 75 object(s) allocated from:
    #1 QGraphicsSimpleTextItem::QGraphicsSimpleTextItem(QGraphicsItem*)
    #2 ElementPictureFactory::parseText(...) elementpicturefactory.cpp:658
    #4 ElementPictureFactory::build(...) elementpicturefactory.cpp:324

Give the low-zoom pass one set of primitives for the whole element and
delete its text items when both pictures are drawn; in dropCache(),
take the primitives out of the hash and delete their text items. The
items kept in m_primitives_H for the DXF export are unchanged, and the
destructor deletes those as before.

No file-format change, nothing drawn differently. Tests: the
sanitizer job on Linux fails on master with the report above and
passes with this change; ctest on macOS 64/64. The leak is invisible
to a plain test and to ASan on macOS, which has no LeakSanitizer.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Beat Hangartner <beat@hangartners.ch>

2026-10-06 17:42:19 +02:00

..

autoNum

Fix jump to element search.

2026-10-04 01:04:44 +02:00

dataBase

Merge pull request #1320 from bhangart/feature/free-text-width

2026-10-06 16:18:25 +02:00

diagramevent

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

dvevent

One year

2026-01-16 15:24:35 +01:00

dxf

dxf2elmt: point link to general release directory instead of special version

2026-01-26 18:47:43 +01:00

editor

Merge pull request #1323 from bhangart/fix/element-editor-text-field-width-anchor

2026-10-06 16:23:53 +02:00

ElementsCollection

Merge pull request #1243 from ispyisail/fix/element-long-paths

2026-10-02 13:13:33 +02:00

factory

Delete the text items ElementPictureFactory::build() creates and drops

2026-10-06 17:42:19 +02:00

import/edz

fix deprecation-warning about "setContent" with qt >= 6.5

2026-08-17 10:25:44 +02:00

logging

Say what crashed and where in Windows crash reports

2026-10-01 07:40:57 +13:00

materiallist

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

NameList

Loaded icons by theme name and removed the PNGs nothing uses

2026-10-02 05:47:40 -05:00

print

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

project

Add a local, per-project time-spent tracker (#576)

2026-07-31 09:52:32 +12:00

properties

Cross references at the folio bottom: stack only when texts overlap, add a checkbox (#1287 follow-up)

2026-10-05 17:24:11 +13:00

PropertiesEditor

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

qet_elementscaler

use "%" for string-concatenation

2025-05-22 21:33:32 +02:00

qetgraphicsitem

Merge pull request #1320 from bhangart/feature/free-text-width

2026-10-06 16:18:25 +02:00

QetGraphicsItemModeler

Keep the text resize handles working after a scene change

2026-10-06 09:46:17 +02:00

QPropertyUndoCommand

Fixing undo operations of graphs and images. Changing undo names.

2026-09-07 10:44:30 +02:00

QWidgetAnimation

One year

2026-01-16 15:24:35 +01:00

richtext

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

scripting

Merge pull request #1334 from ispyisail/fix/msvc-qprinter-copy

2026-10-06 16:36:58 +02:00

SearchAndReplace

Served the remaining Breeze icons from ico/breeze and dropped unused icon files (#1269)

2026-10-03 12:20:38 -05:00

spacemouse

Mention ConnexionBackend in SpaceMouseBackend's class comment

2026-09-25 23:25:27 +12:00

svg

One year

2026-01-16 15:24:35 +01:00

TerminalStrip

Fix the free terminal table staying empty after a move (#1306)

2026-10-06 22:02:11 +13:00

titleblock

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

ui

Add icons, menu locations, key search and copy to the Shortcuts page

2026-10-06 08:17:16 +13:00

undocommand

Merge pull request #1282 from arummler/formula-improvements

2026-10-04 11:52:56 +02:00

utils

Merge pull request #1314 from ispyisail/feature/live-remember

2026-10-05 22:14:31 +13:00

xml

One year

2026-01-16 15:24:35 +01:00

alignment.h

Align: a group reduced to one shape lines up on its own centre

2026-09-28 09:19:59 +13:00

autobreakconductor.cpp

autoBreakConductors: share conductors_handled/used_terminals across batch

2026-08-09 09:11:40 +02:00

autobreakconductor.h

autoBreakConductors: share conductors_handled/used_terminals across batch

2026-08-09 09:11:40 +02:00

bomexport.cpp

Add options to leave junctions and contact blocks out of the parts list (#1178)

2026-10-05 22:08:44 +13:00

bomexport.h

Add options to leave junctions and contact blocks out of the parts list (#1178)

2026-10-05 22:08:44 +13:00

bordercelllabels.h

Add an option to keep the folio row and column headers visible (#1034)

2026-09-26 08:22:12 +12:00

borderproperties.cpp

One year

2026-01-16 15:24:35 +01:00

borderproperties.h

One year

2026-01-16 15:24:35 +01:00

bordertitleblock.cpp

Put the DXF export on named layers (#1071)

2026-09-27 21:54:44 +13:00

bordertitleblock.h

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

cellruler.cpp

Cell rulers: line the top ruler up with the columns when the row header is hidden

2026-09-26 21:18:35 +12:00

cellruler.h

Cell rulers: no ghost labels on Windows, hidden while the folio's own header shows

2026-09-26 21:06:13 +12:00

cli_export.cpp

Add options to leave junctions and contact blocks out of the parts list (#1178)

2026-10-05 22:08:44 +13:00

cli_export.h

Add options to leave junctions and contact blocks out of the parts list (#1178)

2026-10-05 22:08:44 +13:00

commandsearchpopup.cpp

Add a command search: type part of a command's name, press Enter

2026-09-26 21:34:02 +12:00

commandsearchpopup.h

Add a command search: type part of a command's name, press Enter

2026-09-26 21:34:02 +12:00

conductorautonumerotation.cpp

Cover auto-numbering counter changes with undo/redo

2026-08-03 13:19:51 +12:00

conductorautonumerotation.h

One year

2026-01-16 15:24:35 +01:00

conductormultiedit.h

Multi-wire panel: stable first wire, mixed fields, locked text, one reload

2026-10-02 06:20:17 +13:00

conductornumexport.cpp

Merge branch 'master' into fix/wire-name-export-double-count-forum3125

2026-09-12 23:06:15 +12:00

conductornumexport.h

One year

2026-01-16 15:24:35 +01:00

conductorprofile.cpp

One year

2026-01-16 15:24:35 +01:00

conductorprofile.h

One year

2026-01-16 15:24:35 +01:00

conductorproperties.cpp

Fix the wire properties panel changing properties nobody edited

2026-10-01 23:10:15 +13:00

conductorproperties.h

Fix the wire properties panel changing properties nobody edited

2026-10-01 23:10:15 +13:00

conductorrouter.cpp

Routing: no loops between close symbols, and route inside frames

2026-10-03 08:43:27 +13:00

conductorrouter.h

Routing: no loops between close symbols, and route inside frames

2026-10-03 08:43:27 +13:00

conductorsegment.cpp

One year

2026-01-16 15:24:35 +01:00

conductorsegment.h

One year

2026-01-16 15:24:35 +01:00

conductorsegmentprofile.h

One year

2026-01-16 15:24:35 +01:00

configdialog.cpp

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

configdialog.h

One year

2026-01-16 15:24:35 +01:00

contactusage.h

Revert the isFull() change: max_slaves counts slots, not contacts

2026-09-09 11:45:36 +12:00

createdxf.cpp

DXF export: colour BYLAYER where QElectroTech sets no colour (#1071)

2026-09-27 21:54:44 +13:00

createdxf.h

Put the DXF export on named layers (#1071)

2026-09-27 21:54:44 +13:00

diagram.cpp

Merge pull request #1282 from arummler/formula-improvements

2026-10-04 11:52:56 +02:00

diagram.h

Zoom to content: count only visible items

2026-10-04 11:23:26 +13:00

diagramcommands.cpp

Fix jump to element search.

2026-10-04 01:04:44 +02:00

diagramcommands.h

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

diagramcontent.cpp

Fix a group splitting apart when one of its items is locked (#1146)

2026-09-29 23:23:32 +13:00

diagramcontent.h

Fix a group splitting apart when one of its items is locked (#1146)

2026-09-29 23:23:32 +13:00

diagramcontext.cpp

Fix Project properties > OK marking the project modified with no edit

2026-10-02 21:04:54 +13:00

diagramcontext.h

Standarize pugixml header path to recommended variant with target INTERFACE.

2026-09-22 09:07:27 +02:00

diagramcontexttoolbar.cpp

Open the text orientation dialog at the texts' current angle

2026-09-28 06:16:17 +13:00

diagramcontexttoolbar.h

Show the selection's commands beside the cursor after a click

2026-09-26 21:40:32 +12:00

diagramgestureoverlay.cpp

Run commands with right-drag mouse gestures

2026-09-26 21:40:46 +12:00

diagramgestureoverlay.h

Run commands with right-drag mouse gestures

2026-09-26 21:40:46 +12:00

diagramposition.cpp

DiagramPosition: compile the letter filter once

2026-09-27 11:16:37 +13:00

diagramposition.h

One year

2026-01-16 15:24:35 +01:00

diagramsortkeys.h

Add a unit test locking in Diagram::toXml()'s coordinate sort order

2026-09-07 20:54:18 +12:00

diagramview.cpp

Merge pull request #1282 from arummler/formula-improvements

2026-10-04 11:52:56 +02:00

diagramview.h

Add a "Centre on cursor" view command

2026-10-01 10:29:34 +13:00

dxfexport.cpp

Export wrapped texts to DXF line by line

2026-10-05 18:00:26 +02:00

dxfexport.h

Put the DXF export on named layers (#1071)

2026-09-27 21:54:44 +13:00

dxfpaintdevice.cpp

Connected to previous image handling updates: images were not exported at all to dxf. In this

2026-09-07 10:44:30 +02:00

dxfpaintdevice.h

Connected to previous image handling updates: images were not exported at all to dxf. In this

2026-09-07 10:44:30 +02:00

elementdialog.cpp

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

elementdialog.h

makro

2026-04-26 10:48:47 +02:00

elementprovider.cpp

Replace deprecated qAsConst with std::as_const

2026-07-14 19:27:16 +02:00

elementprovider.h

One year

2026-01-16 15:24:35 +01:00

elementscategoryeditor.cpp

Remember dialog size and position across sessions

2026-09-30 10:31:12 +13:00

elementscategoryeditor.h

One year

2026-01-16 15:24:35 +01:00

elementscollectioncache.cpp

Let the Collections and Projects panels follow the palette

2026-09-19 12:22:24 -05:00

elementscollectioncache.h

One year

2026-01-16 15:24:35 +01:00

elementsmover.cpp

Fix a group splitting apart when one of its items is locked (#1146)

2026-09-29 23:23:32 +13:00

elementsmover.h

Fix a group splitting apart when one of its items is locked (#1146)

2026-09-29 23:23:32 +13:00

elementspanel.cpp

Loaded icons by theme name and removed the PNGs nothing uses

2026-10-02 05:47:40 -05:00

elementspanel.h

Fix and Improve Multi-selection for Diagram Operations

2026-05-13 19:42:11 +02:00

elementspanelwidget.cpp

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

elementspanelwidget.h

Add "Insert folio above/below" to the elements panel's folio menu

2026-08-04 16:36:23 +12:00

elementtextpattern.cpp

One year

2026-01-16 15:24:35 +01:00

elementtextpattern.h

One year

2026-01-16 15:24:35 +01:00

elementtextsmover.cpp

Reset the element text mover after a drag that ends where it started

2026-09-26 10:36:40 +12:00

elementtextsmover.h

Share the text grid choices; add a preference, a status hint and a unit test

2026-09-26 10:22:50 +12:00

exportdialog.cpp

View > Show: no DXF picture warning when pictures are hidden

2026-10-04 01:32:03 +13:00

exportdialog.h

Add DXF export from the command line (--export-dxf)

2026-09-27 21:54:36 +13:00

exportproperties.cpp

set to false

2026-08-08 08:09:45 +02:00

exportproperties.h

new Checkbox

2026-08-06 21:37:40 +02:00

exportpropertieswidget.cpp

Re-adding connects (migrated) which got lost unfortunately during the migration and repeated merging.

2026-08-09 19:25:56 +02:00

exportpropertieswidget.h

new Checkbox

2026-08-06 21:37:40 +02:00

genericpanel.cpp

Fix a use-after-free when closing QElectroTech without saving

2026-10-02 16:15:51 +13:00

genericpanel.h

Fix losing Focus on moving diagram position with keyboard

2026-04-19 10:44:52 +02:00

itemgroups.cpp

Merge pull request #1111 from ispyisail/feat/1070-rotate-whole-group

2026-09-28 14:55:04 +02:00

itemgroups.h

Merge pull request #1111 from ispyisail/feat/1070-rotate-whole-group

2026-09-28 14:55:04 +02:00

lastusedstyle.cpp

Remember the F2 conductor color for the rest of the session (#879)

2026-09-16 15:40:41 +12:00

lastusedstyle.h

Remember the F2 conductor color for the rest of the session (#879)

2026-09-16 15:40:41 +12:00

machine_info.cpp

Remove all code switches for Qt<6 with one exception: caching in titlebordertemplate. Function for caching not called since Qt4; might profit from complete removal.

2026-09-17 00:07:46 +02:00

machine_info.h

Fix three uninitialised-value bugs found by Valgrind

2026-06-20 22:31:06 +12:00

main.cpp

Merge pull request #1257 from ispyisail/feature/pdf-reproducible

2026-10-02 23:15:05 +02:00

newelementwizard.cpp

Served the app icon from the icon theme in the new element wizard

2026-10-04 10:16:34 -05:00

newelementwizard.h

One year

2026-01-16 15:24:35 +01:00

palettegraphicsview.cpp

Add diagram background color picker with adaptive border/titleblock

2026-09-20 22:58:08 +02:00

palettegraphicsview.h

Add an option to draw the folio cell limits across the drawing

2026-09-26 21:17:19 +12:00

pdf_links.cpp

Fix repeatable PDF changing with the output folder (#1178)

2026-10-05 21:43:28 +13:00

pdf_links.h

Give a repeatable PDF the same document id however the project was made (#1178)

2026-10-04 08:54:13 +13:00

projectview.cpp

Fix:

2026-09-18 18:28:48 +02:00

projectview.h

Fixing MacOS only GUI adjustment relying on QWheelEvent->delta() which was removed in Qt6. Some simplification was possible but no test due to lack of OS.

2026-08-12 12:29:56 +02:00

qet.cpp

Fix bugtracker #266: skip shapes with a nan coordinate in the element editor

2026-10-01 15:21:51 +13:00

qet.h

Fix bugtracker #266: skip shapes with a nan coordinate in the element editor

2026-10-01 15:21:51 +13:00

qetapp.cpp

Honour --common-elements-dir and the other folder options in headless runs

2026-10-03 09:33:24 +13:00

qetapp.h

Add View > Show to hide texts, shapes, pictures by kind (bugtracker #301)

2026-10-03 19:44:12 +13:00

qetarguments.cpp

One year

2026-01-16 15:24:35 +01:00

qetarguments.h

One year

2026-01-16 15:24:35 +01:00

qetdiagrameditor.cpp

Add the missing folio editor commands to the Shortcuts page

2026-10-05 22:54:49 +13:00

qetdiagrameditor.h

Add View > Show to hide texts, shapes, pictures by kind (bugtracker #301)

2026-10-03 19:44:12 +13:00

qeticons.cpp

Sorted the icon folders by source and added ico/README.md

2026-10-04 07:28:56 -05:00

qeticons.h

Served the remaining Breeze icons from ico/breeze and dropped unused icon files (#1269)

2026-10-03 12:20:38 -05:00

qetinformation.cpp

Merge pull request #723 from IBSYSLevi/feature/cabinet-layout

2026-09-16 18:51:34 +12:00

qetinformation.h

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

qetmainwindow.cpp

Add the missing folio editor commands to the Shortcuts page

2026-10-05 22:54:49 +13:00

qetmainwindow.h

Add saving and loading the configuration to a file (discussion #610)

2026-09-30 10:42:26 +13:00

qetmessagebox.cpp

Fix command-line tools hanging forever on a modal message box

2026-08-05 05:26:57 +12:00

qetmessagebox.h

Fix command-line tools hanging forever on a modal message box

2026-08-05 05:26:57 +12:00

qetpalette.cpp

Add custom application color picker in global settings

2026-09-21 22:05:31 +02:00

qetpalette.h

Refresh style-sheet widgets after a live palette switch

2026-09-20 12:20:01 -05:00

qetproject.cpp

Fix jump to element search.

2026-10-04 01:04:44 +02:00

qetproject.h

AutoNum: a lot of changes

2026-10-03 18:09:33 +02:00

qetregexpvalidator.cpp

One year

2026-01-16 15:24:35 +01:00

qetregexpvalidator.h

One year

2026-01-16 15:24:35 +01:00

qetresult.cpp

One year

2026-01-16 15:24:35 +01:00

qetresult.h

One year

2026-01-16 15:24:35 +01:00

qetstyle.cpp

Darken the hover ink on a light button face

2026-09-20 12:45:07 -05:00

qetstyle.h

Give icons a hover state through a proxy style

2026-09-19 12:26:06 -05:00

qetversion.cpp

Update QVersionNumber to 0, 200, 1

2026-08-16 07:16:33 +02:00

qetversion.h

One year

2026-01-16 15:24:35 +01:00

qetxml.cpp

Remove all code switches for Qt<6 with one exception: caching in titlebordertemplate. Function for caching not called since Qt4; might profit from complete removal.

2026-09-17 00:07:46 +02:00

qetxml.h

Fix remaining Qt6 build errors after PR #540

2026-07-17 10:25:49 +02:00

qfilenameedit.cpp

Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.

2026-08-08 00:32:31 +02:00

qfilenameedit.h

One year

2026-01-16 15:24:35 +01:00

qgimanager.cpp

Remove all code switches for Qt<6 with one exception: caching in titlebordertemplate. Function for caching not called since Qt4; might profit from complete removal.

2026-09-17 00:07:46 +02:00

qgimanager.h

Remove all code switches for Qt<6 with one exception: caching in titlebordertemplate. Function for caching not called since Qt4; might profit from complete removal.

2026-09-17 00:07:46 +02:00

qtextorientationspinboxwidget.cpp

Migration of signal/slot to method pointer continued. Mostly simple cases.

2026-08-09 01:34:22 +02:00

qtextorientationspinboxwidget.h

One year

2026-01-16 15:24:35 +01:00

qtextorientationwidget.cpp

Remove all code switches for Qt<6 with one exception: caching in titlebordertemplate. Function for caching not called since Qt4; might profit from complete removal.

2026-09-17 00:07:46 +02:00

qtextorientationwidget.h

One year

2026-01-16 15:24:35 +01:00

recentfiles.cpp

Fix : can't open recent file

2026-07-17 10:29:13 +02:00

recentfiles.h

Fix : can't open recent file

2026-07-17 10:29:13 +02:00

shortcutbarsettings.cpp

Merge pull request #1060 from ispyisail/feature/shortcut-bar-symbols

2026-09-27 09:09:44 +02:00

shortcutbarsettings.h

Merge pull request #1060 from ispyisail/feature/shortcut-bar-symbols

2026-09-27 09:09:44 +02:00

shortcutmanager.cpp

Add icons, menu locations, key search and copy to the Shortcuts page

2026-10-06 08:17:16 +13:00

shortcutmanager.h

Add icons, menu locations, key search and copy to the Shortcuts page

2026-10-06 08:17:16 +13:00

shownkinds.cpp

View > Show: keep the wire text of a potential when its wire is deleted

2026-10-04 00:07:16 +13:00

shownkinds.h

View > Show: keep the wire text of a potential when its wire is deleted

2026-10-04 00:07:16 +13:00

textanchor.h

Position X/Y of a symbol text is the point chosen by its alignment

2026-09-30 18:12:43 +13:00

textgrid.h

Share the text grid choices; add a preference, a status hint and a unit test

2026-09-26 10:22:50 +12:00

textlines.h

Keep the DXF text lines of master for texts that do not wrap

2026-10-06 09:53:49 +02:00

textresize.h

Add corner handles to change the width of a text box

2026-10-05 17:53:38 +02:00

titleblockcell.cpp

Wrap code for better readability

2020-09-07 22:03:40 +02:00

titleblockcell.h

One year

2026-01-16 15:24:35 +01:00

titleblockproperties.cpp

One year

2026-01-16 15:24:35 +01:00

titleblockproperties.h

One year

2026-01-16 15:24:35 +01:00

titleblocktemplate.cpp

Fix #1113: custom title-block variables in Find/Replace and unset placeholders

2026-09-29 09:59:21 +13:00

titleblocktemplate.h

Fix #1113: custom title-block variables in Find/Replace and unset placeholders

2026-09-29 09:59:21 +13:00

titleblocktemplaterenderer.cpp

Remove titleblocktemplate cahing remains.

2026-09-17 00:07:46 +02:00

titleblocktemplaterenderer.h

Remove titleblocktemplate cahing remains.

2026-09-17 00:07:46 +02:00

wirehops.cpp

Add optional hops where wires cross (#436)

2026-10-01 21:18:12 +13:00

wirehops.h

Add optional hops where wires cross (#436)

2026-10-01 21:18:12 +13:00

wiringlistexport.cpp

Add a Cable column to the wiring list export

2026-10-01 16:50:56 +13:00

wiringlistexport.h

Add a Cable column to the wiring list export

2026-10-01 16:50:56 +13:00

wiringrules.cpp

Merge branch 'feature/wires-per-terminal' into feature/wires-per-terminal-chains

2026-10-04 01:43:37 +13:00

wiringrules.h

Merge branch 'feature/wires-per-terminal' into feature/wires-per-terminal-chains

2026-10-04 01:43:37 +13:00