kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-09-28 13:24:14 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
Files
edf483d88f5e7ff74eff639978eb0f380cc2e733
qelectrotech-source-mirror/sources
T
History
Jeff Patterson edf483d88f Delete a terminal's conductors from a snapshot of its conductor list 
Terminal::~Terminal() called qDeleteAll(m_conductors_list) on the live
member. Each Conductor destructor calls removeConductor() on both of its
terminals, and that removes the conductor from the same list qDeleteAll
is iterating. Mutating a QList while iterating it is undefined
behaviour; with two or more conductors on one terminal (terminal strips,
bridged terminals) it can skip a delete or delete one conductor twice,
which leaves another conductor's terminal1/terminal2 pointing at freed
memory.

The pattern dates from a00404bc9 (2021), which replaced a foreach loop
(iterating an implicit copy) with a direct qDeleteAll. It went unnoticed
until the deterministic sort keys added to Diagram::toXml() in #844
started reading pos() on both terminals of every conductor on every
save, including the periodic backup, which turned the stale pointer into
an EXC_BAD_ACCESS in QGraphicsItem::pos() while deleting an element.

Copy the list first and delete from the copy, restoring the pre-2021
behaviour. An isolated regression test (a hub terminal with 2 to 8
conductors, under AddressSanitizer) did not trigger the failure with the
old code, so none is included; the crash analysis and that attempt are
recorded in jp2images/qelectrotech-source-mirror#1.
2026-09-16 04:27:27 -05:00
..
autoNum
Import automatic numbering rules from another project
2026-09-13 09:56:25 +12:00
dataBase
Fix bugtracker #885: preserve custom summary-table SQL on accept
2026-09-16 13:09:48 +12:00
diagramevent
Paste under the cursor and let it be positioned before it lands
2026-09-15 17:07:15 +12:00
dvevent
One year
2026-01-16 15:24:35 +01:00
dxf
dxf2elmt: point link to general release directory instead of special version
2026-01-26 18:47:43 +01:00
editor
Merge pull request #723 from IBSYSLevi/feature/cabinet-layout
2026-09-16 18:51:34 +12:00
ElementsCollection
Fix crash when expanding templates/macros tree (Qt6 regression)
2026-08-27 07:27:25 +02:00
factory
Merge pull request #842 from ispyisail/fix/element-picture-cache-key
2026-09-12 11:41:36 +02:00
import/edz
fix deprecation-warning about "setContent" with qt >= 6.5
2026-08-17 10:25:44 +02:00
logging
Add an event-loop responsiveness watchdog (discussion #644 follow-up)
2026-08-06 23:05:05 +12:00
NameList
Fall back to the base language for element and folder names
2026-07-11 21:47:04 +02:00
print
FIX compile-warnings
2026-08-22 13:34:29 +02:00
project
Add a local, per-project time-spent tracker (#576)
2026-07-31 09:52:32 +12:00
properties
Add smart device metadata to element information
2026-09-11 20:11:19 +03:00
PropertiesEditor
Fix bugtracker #275: element properties window stuck centered on macOS
2026-08-11 11:48:58 +12:00
qet_elementscaler
use "%" for string-concatenation
2025-05-22 21:33:32 +02:00
qetgraphicsitem
Delete a terminal's conductors from a snapshot of its conductor list
2026-09-16 04:27:27 -05:00
QetGraphicsItemModeler
One year
2026-01-16 15:24:35 +01:00
QPropertyUndoCommand
Fixing undo operations of graphs and images. Changing undo names.
2026-09-07 10:44:30 +02:00
QWidgetAnimation
One year
2026-01-16 15:24:35 +01:00
richtext
FIX compile-warnings
2026-08-22 13:34:29 +02:00
SearchAndReplace
Scroll the diagram view to the selected search hit
2026-08-10 21:19:56 +12:00
svg
One year
2026-01-16 15:24:35 +01:00
TerminalStrip
remove #include that's already in own header-file
2026-08-17 16:46:49 +02:00
titleblock
Clean up readSettingsState() in all three editors
2026-08-23 18:25:23 +02:00
ui
Merge pull request #723 from IBSYSLevi/feature/cabinet-layout
2026-09-16 18:51:34 +12:00
undocommand
Add editable resize/rotate/skew handles for shapes and images
2026-09-05 15:48:28 +02:00
utils
Remove all Qt version checks and branches for <5.14.0 as such versions are no longer supported.
2026-08-13 15:45:15 +02:00
xml
One year
2026-01-16 15:24:35 +01:00
autobreakconductor.cpp
autoBreakConductors: share conductors_handled/used_terminals across batch
2026-08-09 09:11:40 +02:00
autobreakconductor.h
autoBreakConductors: share conductors_handled/used_terminals across batch
2026-08-09 09:11:40 +02:00
bomexport.cpp
Include slave and terminal elements in the bill of materials
2026-09-13 02:00:50 +12:00
bomexport.h
Address smart device BOM review feedback
2026-09-11 20:12:09 +03:00
borderproperties.cpp
One year
2026-01-16 15:24:35 +01:00
borderproperties.h
One year
2026-01-16 15:24:35 +01:00
bordertitleblock.cpp
Fix #531: page-level empty title block variable no longer shadows project-level value
2026-07-30 18:32:54 +12:00
bordertitleblock.h
Change comment style for title block edge method
2026-08-13 08:50:24 +08:00
cli_export.cpp
Address smart device BOM review feedback
2026-09-11 20:12:09 +03:00
cli_export.h
Merge pull request #629 from ispyisail/feature-wiring-list-view
2026-09-10 22:44:27 +02:00
conductorautonumerotation.cpp
Cover auto-numbering counter changes with undo/redo
2026-08-03 13:19:51 +12:00
conductorautonumerotation.h
One year
2026-01-16 15:24:35 +01:00
conductornumexport.cpp
Merge branch 'master' into fix/wire-name-export-double-count-forum3125
2026-09-12 23:06:15 +12:00
conductornumexport.h
One year
2026-01-16 15:24:35 +01:00
conductorprofile.cpp
One year
2026-01-16 15:24:35 +01:00
conductorprofile.h
One year
2026-01-16 15:24:35 +01:00
conductorproperties.cpp
Remove all Qt version checks and branches for <5.14.0 as such versions are no longer supported.
2026-08-13 15:45:15 +02:00
conductorproperties.h
One year
2026-01-16 15:24:35 +01:00
conductorsegment.cpp
One year
2026-01-16 15:24:35 +01:00
conductorsegment.h
One year
2026-01-16 15:24:35 +01:00
conductorsegmentprofile.h
One year
2026-01-16 15:24:35 +01:00
configdialog.cpp
Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.
2026-08-08 00:32:31 +02:00
configdialog.h
One year
2026-01-16 15:24:35 +01:00
contactusage.h
Revert the isFull() change: max_slaves counts slots, not contacts
2026-09-09 11:45:36 +12:00
createdxf.cpp
One year
2026-01-16 15:24:35 +01:00
createdxf.h
One year
2026-01-16 15:24:35 +01:00
diagram.cpp
Persist the folio uuid, derived deterministically for legacy folios
2026-09-15 22:09:10 +00:00
diagram.h
Persist the folio uuid, derived deterministically for legacy folios
2026-09-15 22:09:10 +00:00
diagramcommands.cpp
Clear PLC slave data on paste
2026-09-13 12:58:43 +02:00
diagramcommands.h
Fix paste breaking existing conductors
2026-08-22 11:25:47 +02:00
diagramcontent.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
diagramcontent.h
One year
2026-01-16 15:24:35 +01:00
diagramcontext.cpp
One year
2026-01-16 15:24:35 +01:00
diagramcontext.h
One year
2026-01-16 15:24:35 +01:00
diagramposition.cpp
One year
2026-01-16 15:24:35 +01:00
diagramposition.h
One year
2026-01-16 15:24:35 +01:00
diagramsortkeys.h
Add a unit test locking in Diagram::toXml()'s coordinate sort order
2026-09-07 20:54:18 +12:00
diagramview.cpp
Remember the F2 conductor color for the rest of the session (#879)
2026-09-16 15:40:41 +12:00
diagramview.h
Let Escape step back out of the folio, so Tab cannot trap keyboard users
2026-09-15 11:32:42 +12:00
dxfpaintdevice.cpp
Connected to previous image handling updates: images were not exported at all to dxf. In this
2026-09-07 10:44:30 +02:00
dxfpaintdevice.h
Connected to previous image handling updates: images were not exported at all to dxf. In this
2026-09-07 10:44:30 +02:00
elementdialog.cpp
Fix invisible element icons on dark themes in Open/Save Element and New Element Wizard dialogs
2026-08-08 21:53:20 +12:00
elementdialog.h
makro
2026-04-26 10:48:47 +02:00
elementprovider.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
elementprovider.h
One year
2026-01-16 15:24:35 +01:00
elementscategoryeditor.cpp
Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.
2026-08-08 00:32:31 +02:00
elementscategoryeditor.h
One year
2026-01-16 15:24:35 +01:00
elementscollectioncache.cpp
Wrap deprecated QSqlDatabase::exec() in QSqlQuery
2026-07-14 19:27:17 +02:00
elementscollectioncache.h
One year
2026-01-16 15:24:35 +01:00
elementsmover.cpp
autoBreakConductors: share conductors_handled/used_terminals across batch
2026-08-09 09:11:40 +02:00
elementsmover.h
One year
2026-01-16 15:24:35 +01:00
elementspanel.cpp
Remaining signal/slot migration and clean-up after the latest merge.
2026-08-09 11:51:23 +02:00
elementspanel.h
Fix and Improve Multi-selection for Diagram Operations
2026-05-13 19:42:11 +02:00
elementspanelwidget.cpp
Merge pull request #628 from ispyisail/feature-wiring-db-tables
2026-08-21 14:03:02 +02:00
elementspanelwidget.h
Add "Insert folio above/below" to the elements panel's folio menu
2026-08-04 16:36:23 +12:00
elementtextpattern.cpp
One year
2026-01-16 15:24:35 +01:00
elementtextpattern.h
One year
2026-01-16 15:24:35 +01:00
elementtextsmover.cpp
One year
2026-01-16 15:24:35 +01:00
elementtextsmover.h
One year
2026-01-16 15:24:35 +01:00
exportdialog.cpp
Connected to previous image handling updates: images were not exported at all to dxf. In this
2026-09-07 10:44:30 +02:00
exportdialog.h
One year
2026-01-16 15:24:35 +01:00
exportproperties.cpp
set to false
2026-08-08 08:09:45 +02:00
exportproperties.h
new Checkbox
2026-08-06 21:37:40 +02:00
exportpropertieswidget.cpp
Re-adding connects (migrated) which got lost unfortunately during the migration and repeated merging.
2026-08-09 19:25:56 +02:00
exportpropertieswidget.h
new Checkbox
2026-08-06 21:37:40 +02:00
genericpanel.cpp
fix
2026-09-03 15:05:22 +02:00
genericpanel.h
Fix losing Focus on moving diagram position with keyboard
2026-04-19 10:44:52 +02:00
lastusedstyle.cpp
Remember the F2 conductor color for the rest of the session (#879)
2026-09-16 15:40:41 +12:00
lastusedstyle.h
Remember the F2 conductor color for the rest of the session (#879)
2026-09-16 15:40:41 +12:00
machine_info.cpp
QETApp: fall back to English when the QET translation is empty
2026-09-11 16:28:11 +02:00
machine_info.h
Fix three uninitialised-value bugs found by Valgrind
2026-06-20 22:31:06 +12:00
main.cpp
Merge pull request #661 from ispyisail/fix-cli-modal-dialog-hang
2026-09-11 07:10:15 +12:00
newelementwizard.cpp
Fix bugtracker #281: new-part wizard's element editor opens behind main window
2026-08-11 11:33:28 +12:00
newelementwizard.h
One year
2026-01-16 15:24:35 +01:00
pdf_links.cpp
fix problem with PDF-links in files with brackets in name
2026-08-24 18:24:30 +02:00
pdf_links.h
fix
2026-08-14 08:58:36 +02:00
projectview.cpp
Fix: avoid crash when opening a project without a folio (diagram).
2026-08-28 19:55:29 +02:00
projectview.h
Fixing MacOS only GUI adjustment relying on QWheelEvent->delta() which was removed in Qt6. Some simplification was possible but no test due to lack of OS.
2026-08-12 12:29:56 +02:00
qet.cpp
Fix bugtracker #248: opening a file while QET is running does nothing
2026-09-14 14:55:17 +12:00
qet.h
One year
2026-01-16 15:24:35 +01:00
qetapp.cpp
Fix indentation of the deferred-open comment block
2026-09-14 22:14:36 +12:00
qetapp.h
QETApp: fall back to English when the QET translation is empty
2026-09-11 16:28:11 +02:00
qetarguments.cpp
One year
2026-01-16 15:24:35 +01:00
qetarguments.h
One year
2026-01-16 15:24:35 +01:00
qetdiagrameditor.cpp
Merge pull request #874 from ispyisail/feature/diagram-selection-shortcuts-v2
2026-09-15 10:20:28 +02:00
qetdiagrameditor.h
Address smart device BOM review feedback
2026-09-11 20:12:09 +03:00
qeticons.cpp
Adding icons to graphs and image operations.
2026-09-07 10:44:30 +02:00
qeticons.h
Adding icons to graphs and image operations.
2026-09-07 10:44:30 +02:00
qetinformation.cpp
Merge pull request #723 from IBSYSLevi/feature/cabinet-layout
2026-09-16 18:51:34 +12:00
qetinformation.h
Merge pull request #723 from IBSYSLevi/feature/cabinet-layout
2026-09-16 18:51:34 +12:00
qetmainwindow.cpp
Correct the comment: say what was measured, not what was assumed
2026-09-15 15:51:24 +12:00
qetmainwindow.h
Open the menu bar on F10, and add a test that can answer whether it works
2026-09-15 13:44:59 +12:00
qetmessagebox.cpp
Fix command-line tools hanging forever on a modal message box
2026-08-05 05:26:57 +12:00
qetmessagebox.h
Fix command-line tools hanging forever on a modal message box
2026-08-05 05:26:57 +12:00
qetproject.cpp
Persist the project uuid, derived from the file content for legacy files
2026-09-15 23:34:24 +00:00
qetproject.h
Persist the project uuid, derived from the file content for legacy files
2026-09-15 23:34:24 +00:00
qetregexpvalidator.cpp
One year
2026-01-16 15:24:35 +01:00
qetregexpvalidator.h
One year
2026-01-16 15:24:35 +01:00
qetresult.cpp
One year
2026-01-16 15:24:35 +01:00
qetresult.h
One year
2026-01-16 15:24:35 +01:00
qetversion.cpp
Update QVersionNumber to 0, 200, 1
2026-08-16 07:16:33 +02:00
qetversion.h
One year
2026-01-16 15:24:35 +01:00
qetxml.cpp
Write model header data sections in a stable order
2026-09-12 23:27:46 +12:00
qetxml.h
Fix remaining Qt6 build errors after PR #540
2026-07-17 10:25:49 +02:00
qfilenameedit.cpp
Update old fashioned SIGNAL/SLOT to point-to-member. Only simple and clear cases.
2026-08-08 00:32:31 +02:00
qfilenameedit.h
One year
2026-01-16 15:24:35 +01:00
qgimanager.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
qgimanager.h
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
qtextorientationspinboxwidget.cpp
Migration of signal/slot to method pointer continued. Mostly simple cases.
2026-08-09 01:34:22 +02:00
qtextorientationspinboxwidget.h
One year
2026-01-16 15:24:35 +01:00
qtextorientationwidget.cpp
One year
2026-01-16 15:24:35 +01:00
qtextorientationwidget.h
One year
2026-01-16 15:24:35 +01:00
recentfiles.cpp
Fix : can't open recent file
2026-07-17 10:29:13 +02:00
recentfiles.h
Fix : can't open recent file
2026-07-17 10:29:13 +02:00
shortcutmanager.cpp
Replacing depreciated qAsConst with std::as_const
2026-08-12 12:29:56 +02:00
shortcutmanager.h
Add configurable shortcuts: ShortcutManager registry + Shortcuts config page (#574)
2026-08-01 01:35:51 +12:00
titleblockcell.cpp
Wrap code for better readability
2020-09-07 22:03:40 +02:00
titleblockcell.h
One year
2026-01-16 15:24:35 +01:00
titleblockproperties.cpp
One year
2026-01-16 15:24:35 +01:00
titleblockproperties.h
One year
2026-01-16 15:24:35 +01:00
titleblocktemplate.cpp
Guard debug output.
2026-09-12 14:50:22 +02:00
titleblocktemplate.h
TitleBlockTemplate::minimumWidth() divided by (100.0 - sum(RelativeToTotalLength)) without guarding against a zero or negative denominator. When a template's relative-to-total-length
2026-08-08 12:31:45 +02:00
titleblocktemplaterenderer.cpp
Wrap code for better readability
2020-09-07 22:03:40 +02:00
titleblocktemplaterenderer.h
One year
2026-01-16 15:24:35 +01:00
wiringlistexport.cpp
CLI export: add wiring list and wire-number list (CSV)
2026-06-11 12:39:43 +12:00
wiringlistexport.h
CLI export: add wiring list and wire-number list (CSV)
2026-06-11 12:39:43 +12:00