kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-09-20 15:24:14 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Address review

Browse Source 
1. Drop dead prepareGeometryChange()/update() calls in
setPotential(), split unrelated terminaleditor.h re-indent into its
own change

2. Removed: setPotential() had prepareGeometryChange()/update() left over from
the label-display mechanism that was dropped before this PR
This commit is contained in:
Levi Jetzer
2026-09-04 13:12:21 +02:00
parent e410896f5d
commit 1e1039dd32
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sources/editor/graphicspart/partterminal.cpp
-2
View File
@@ -479,9 +479,7 @@ void PartTerminal::setMasterLabelIndex(int index)
void PartTerminal::setPotential(const QString &potential)
{
if (d->m_potential == potential) return;
prepareGeometryChange();
d->m_potential = potential;
update();
emit potentialChanged();
}
sources/editor/ui/terminaleditor.h
+7 -7
View File
@@ -65,13 +65,13 @@ class TerminalEditor : public ElementItemEditor
void labelSizeEdited();
void labelRotationEdited();
void labelAlignClicked();
void labelFrameEdited();
void labelColorClicked();
void activeConnections(bool active);
void activeChangeConnections(bool active);
void useMasterLabelEdited();
void masterLabelIndexEdited();
bool updateMasterLabelVisibility();
void labelFrameEdited();
void labelColorClicked();
void activeConnections(bool active);
void activeChangeConnections(bool active);
void useMasterLabelEdited();
void masterLabelIndexEdited();
bool updateMasterLabelVisibility();
private:
Ui::TerminalEditor *ui;