Kellermorph
23f8e261e5
Element editor: save the moved position of the PLC table
...
Moving the PLC table in the element editor was lost on save: the table
came back at (0, 0) when the element was reopened, and it was drawn at
(0, 0) in the diagram editor as well.
PartPlcTable::toXml() wrote m_rect.x()/y(), which are the coordinates
inside the item, and the move of a part never touches m_rect - it lives
in pos() (CustomElementGraphicPart::mouseMoveEvent, or the decorator for
a multi-selection). m_rect starts at the item origin, so x="0" y="0"
was written whatever the user did, while fromXml() reads those two
attributes as scene coordinates and hands them to setPos(). Every other
part translates first, see PartRectangle::toXml() with sceneTopLeft().
The top-left corner is now mapped to scene coordinates before being
written, which also covers a group transformation, since that one moves
m_rect while pos() stays put.
Both readers of the attribute need no change: ElementScene::fromXml()
for the editor and Element() for the runtime drawing of the table
(Element::drawPlcTable) already expect scene coordinates. Elements that
still carry x="0" y="0" keep loading as before.
Full build clean. Test suite: the same three failures as before the
change (tst_menubarkeyboard, tst_databasefromdocument,
tst_terminaluuids), each of them also failing on a build without this
patch, so they are unrelated.
2026-09-30 20:20:52 +02:00
..
2026-09-30 11:10:02 +02:00
2026-09-29 16:08:45 +13:00
2026-09-30 13:47:45 +13:00
2026-01-16 15:24:35 +01:00
2026-01-26 18:47:43 +01:00
2026-09-30 20:20:52 +02:00
2026-09-30 11:10:02 +02:00
2026-09-30 10:31:12 +13:00
2026-08-17 10:25:44 +02:00
2026-09-30 10:31:12 +13:00
2026-09-30 10:31:12 +13:00
2026-09-30 10:31:12 +13:00
2026-09-25 20:44:02 +12:00
2026-07-31 09:52:32 +12:00
2026-09-24 09:59:21 +02:00
2026-09-30 10:31:12 +13:00
2025-05-22 21:33:32 +02:00
2026-09-30 18:12:43 +13:00
2026-01-16 15:24:35 +01:00
2026-09-07 10:44:30 +02:00
2026-01-16 15:24:35 +01:00
2026-09-30 10:31:12 +13:00
2026-09-29 11:00:16 +13:00
2026-09-30 10:31:12 +13:00
2026-09-25 23:25:27 +12:00
2026-01-16 15:24:35 +01:00
2026-09-30 11:35:25 +13:00
2026-09-30 10:31:12 +13:00
2026-09-30 11:10:02 +02:00
2026-09-29 23:24:50 +13:00
2026-09-30 13:47:45 +13:00
2026-01-16 15:24:35 +01:00
2026-09-28 09:19:59 +13:00
2026-08-09 09:11:40 +02:00
2026-08-09 09:11:40 +02:00
2026-09-13 02:00:50 +12:00
2026-09-11 20:12:09 +03:00
2026-09-26 08:22:12 +12:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-27 21:54:44 +13:00
2026-09-26 07:37:38 +12:00
2026-09-26 21:18:35 +12:00
2026-09-26 21:06:13 +12:00
2026-09-30 07:24:55 +13:00
2026-09-27 21:54:36 +13:00
2026-09-26 21:34:02 +12:00
2026-09-26 21:34:02 +12:00
2026-08-03 13:19:51 +12:00
2026-01-16 15:24:35 +01:00
2026-09-12 23:06:15 +12:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-20 21:56:43 +02:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-30 10:31:12 +13:00
2026-01-16 15:24:35 +01:00
2026-09-09 11:45:36 +12:00
2026-09-27 21:54:44 +13:00
2026-09-27 21:54:44 +13:00
2026-09-29 23:09:57 +13:00
2026-09-29 23:09:57 +13:00
2026-09-27 21:14:47 +13:00
2026-08-22 11:25:47 +02:00
2026-09-29 23:23:32 +13:00
2026-09-29 23:23:32 +13:00
2026-09-28 21:59:02 +13:00
2026-09-22 09:07:27 +02:00
2026-09-28 06:16:17 +13:00
2026-09-26 21:40:32 +12:00
2026-09-26 21:40:46 +12:00
2026-09-26 21:40:46 +12:00
2026-09-27 11:16:37 +13:00
2026-01-16 15:24:35 +01:00
2026-09-07 20:54:18 +12:00
2026-09-30 14:57:13 +13:00
2026-09-30 11:08:55 +13:00
2026-09-27 21:54:44 +13:00
2026-09-27 21:54:44 +13:00
2026-09-07 10:44:30 +02:00
2026-09-07 10:44:30 +02:00
2026-09-30 10:31:12 +13:00
2026-04-26 10:48:47 +02:00
2026-07-14 19:27:16 +02:00
2026-01-16 15:24:35 +01:00
2026-09-30 10:31:12 +13:00
2026-01-16 15:24:35 +01:00
2026-09-19 12:22:24 -05:00
2026-01-16 15:24:35 +01:00
2026-09-29 23:23:32 +13:00
2026-09-29 23:23:32 +13:00
2026-09-19 12:22:24 -05:00
2026-05-13 19:42:11 +02:00
2026-09-27 21:14:47 +13:00
2026-08-04 16:36:23 +12:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-26 10:36:40 +12:00
2026-09-26 10:22:50 +12:00
2026-09-30 10:31:12 +13:00
2026-09-27 21:54:36 +13:00
2026-08-08 08:09:45 +02:00
2026-08-06 21:37:40 +02:00
2026-08-09 19:25:56 +02:00
2026-08-06 21:37:40 +02:00
2026-09-03 15:05:22 +02:00
2026-04-19 10:44:52 +02:00
2026-09-28 14:55:04 +02:00
2026-09-28 14:55:04 +02:00
2026-09-16 15:40:41 +12:00
2026-09-16 15:40:41 +12:00
2026-09-17 00:07:46 +02:00
2026-06-20 22:31:06 +12:00
2026-09-24 21:41:00 +12:00
2026-08-11 11:33:28 +12:00
2026-01-16 15:24:35 +01:00
2026-09-20 22:58:08 +02:00
2026-09-26 21:17:19 +12:00
2026-09-25 20:44:02 +12:00
2026-09-25 20:44:02 +12:00
2026-09-18 18:28:48 +02:00
2026-08-12 12:29:56 +02:00
2026-09-30 10:31:12 +13:00
2026-09-30 10:31:12 +13:00
2026-09-30 11:44:49 +13:00
2026-09-30 10:42:26 +13:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-30 13:47:45 +13:00
2026-09-30 13:47:45 +13:00
2026-09-29 23:37:40 +13:00
2026-09-29 23:37:40 +13:00
2026-09-16 18:51:34 +12:00
2026-09-16 18:51:34 +12:00
2026-09-30 10:42:26 +13:00
2026-09-30 10:42:26 +13:00
2026-08-05 05:26:57 +12:00
2026-08-05 05:26:57 +12:00
2026-09-21 22:05:31 +02:00
2026-09-20 12:20:01 -05:00
2026-09-30 10:45:25 +13:00
2026-09-30 10:45:25 +13:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-20 12:45:07 -05:00
2026-09-19 12:26:06 -05:00
2026-08-16 07:16:33 +02:00
2026-01-16 15:24:35 +01:00
2026-09-17 00:07:46 +02:00
2026-07-17 10:25:49 +02:00
2026-08-08 00:32:31 +02:00
2026-01-16 15:24:35 +01:00
2026-09-17 00:07:46 +02:00
2026-09-17 00:07:46 +02:00
2026-08-09 01:34:22 +02:00
2026-01-16 15:24:35 +01:00
2026-09-17 00:07:46 +02:00
2026-01-16 15:24:35 +01:00
2026-07-17 10:29:13 +02:00
2026-07-17 10:29:13 +02:00
2026-09-27 09:09:44 +02:00
2026-09-27 09:09:44 +02:00
2026-09-28 23:19:46 +02:00
2026-09-26 21:40:19 +12:00
2026-09-30 18:12:43 +13:00
2026-09-26 10:22:50 +12:00
2020-09-07 22:03:40 +02:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-01-16 15:24:35 +01:00
2026-09-29 09:59:21 +13:00
2026-09-29 09:59:21 +13:00
2026-09-17 00:07:46 +02:00
2026-09-17 00:07:46 +02:00
2026-06-11 12:39:43 +12:00
2026-06-11 12:39:43 +12:00