kotschak/qelectrotech-source-mirror
0
0
Fork 0
mirror of https://github.com/qelectrotech/qelectrotech-source-mirror.git synced 2026-07-31 00:24:13 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
Files
96f6fa44ad79349459f51547170ba17e789f6f80
qelectrotech-source-mirror/sources
T
History
Dieter Mayer 96f6fa44ad Replace hash.keys().contains(k) with hash.contains(k) (35 call sites) 
QHash/QMap::keys() allocates a list of every key on each call, then
contains() searches it linearly - an accidental O(n) plus allocation
where a direct O(1) lookup was meant. 35 occurrences across 7 files,
found while profiling project load times (context: #553/#560).

The hot one is ElementPictureFactory::getPictures(), which runs once
per element instance on project load: on the 3399 KiB example project
(191 instances, 129 cache hits) the keys() detour cost 45 ms of the
1.34 s total - measured, not estimated; the fix reproducibly shaves
~35-45 ms off that load. The remaining call sites are UI paths
(search&replace, dynamic text model, undo commands) where the waste
scales with selection/model size.

No behavior change: for QHash/QMap, keys().contains(k) and
contains(k) are equivalent by definition.

(cherry picked from commit 0a7f8f072fa68de7c01a9fc134a4bc8e16d62062)
2026-07-28 13:58:33 +02:00
..
autoNum
Replace deprecated QVariant::canConvert(int)
2026-07-14 19:27:18 +02:00
dataBase
Wrap deprecated QSqlDatabase::exec() in QSqlQuery
2026-07-14 19:27:17 +02:00
diagramevent
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
dvevent
One year
2026-01-16 15:24:35 +01:00
dxf
dxf2elmt: point link to general release directory instead of special version
2026-01-26 18:47:43 +01:00
editor
Merge pull request #519 from ispyisail/fix/asan-memory-leaks
2026-07-19 11:51:47 +02:00
ElementsCollection
Merge pull request #513 from ispyisail/feature/edz-import
2026-07-23 13:58:56 +02:00
factory
Replace hash.keys().contains(k) with hash.contains(k) (35 call sites)
2026-07-28 13:58:33 +02:00
import/edz
edz: make EdzArchive error strings translatable (+ DE/FR)
2026-07-26 21:04:25 +12:00
NameList
Fall back to the base language for element and folder names
2026-07-11 21:47:04 +02:00
print
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
project
One year
2026-01-16 15:24:35 +01:00
properties
Merge pull request #545 from Kellermorph/terminal-name
2026-07-18 08:00:23 +02:00
PropertiesEditor
One year
2026-01-16 15:24:35 +01:00
qet_elementscaler
use "%" for string-concatenation
2025-05-22 21:33:32 +02:00
qetgraphicsitem
Merge pull request #545 from Kellermorph/terminal-name
2026-07-18 08:00:23 +02:00
QetGraphicsItemModeler
One year
2026-01-16 15:24:35 +01:00
QPropertyUndoCommand
One year
2026-01-16 15:24:35 +01:00
QWidgetAnimation
One year
2026-01-16 15:24:35 +01:00
richtext
a few translated shortcuts were still there ... fixed!
2025-02-12 13:41:39 +01:00
SearchAndReplace
Replace hash.keys().contains(k) with hash.contains(k) (35 call sites)
2026-07-28 13:58:33 +02:00
svg
One year
2026-01-16 15:24:35 +01:00
TerminalStrip
terminalstripdrawer.cpp: fix two Qt6 compile errors
2026-07-17 10:26:43 +02:00
titleblock
templatescollection.cpp: fix QDomDocument::ParseResult->bool conversion
2026-07-17 10:26:35 +02:00
ui
Replace hash.keys().contains(k) with hash.contains(k) (35 call sites)
2026-07-28 13:58:33 +02:00
undocommand
Replace hash.keys().contains(k) with hash.contains(k) (35 call sites)
2026-07-28 13:58:33 +02:00
utils
One year
2026-01-16 15:24:35 +01:00
xml
One year
2026-01-16 15:24:35 +01:00
borderproperties.cpp
One year
2026-01-16 15:24:35 +01:00
borderproperties.h
One year
2026-01-16 15:24:35 +01:00
bordertitleblock.cpp
One year
2026-01-16 15:24:35 +01:00
bordertitleblock.h
One year
2026-01-16 15:24:35 +01:00
cli_export.cpp
Guard Qt6-only deprecation replacements for Qt5 compatibility
2026-07-14 19:27:18 +02:00
cli_export.h
CLI: add --set-titleblock to stamp title-block fields headlessly
2026-06-12 05:25:44 +12:00
conductorautonumerotation.cpp
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
conductorautonumerotation.h
One year
2026-01-16 15:24:35 +01:00
conductornumexport.cpp
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
conductornumexport.h
One year
2026-01-16 15:24:35 +01:00
conductorprofile.cpp
One year
2026-01-16 15:24:35 +01:00
conductorprofile.h
One year
2026-01-16 15:24:35 +01:00
conductorproperties.cpp
One year
2026-01-16 15:24:35 +01:00
conductorproperties.h
One year
2026-01-16 15:24:35 +01:00
conductorsegment.cpp
One year
2026-01-16 15:24:35 +01:00
conductorsegment.h
One year
2026-01-16 15:24:35 +01:00
conductorsegmentprofile.h
One year
2026-01-16 15:24:35 +01:00
configdialog.cpp
One year
2026-01-16 15:24:35 +01:00
configdialog.h
One year
2026-01-16 15:24:35 +01:00
createdxf.cpp
One year
2026-01-16 15:24:35 +01:00
createdxf.h
One year
2026-01-16 15:24:35 +01:00
diagram.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
diagram.h
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
diagramcommands.cpp
One year
2026-01-16 15:24:35 +01:00
diagramcommands.h
One year
2026-01-16 15:24:35 +01:00
diagramcontent.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
diagramcontent.h
One year
2026-01-16 15:24:35 +01:00
diagramcontext.cpp
One year
2026-01-16 15:24:35 +01:00
diagramcontext.h
One year
2026-01-16 15:24:35 +01:00
diagramposition.cpp
One year
2026-01-16 15:24:35 +01:00
diagramposition.h
One year
2026-01-16 15:24:35 +01:00
diagramview.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
diagramview.h
makro
2026-04-26 10:48:47 +02:00
elementdialog.cpp
Element editor Save As: label the field as a file name, not element name (#469)
2026-06-12 05:34:20 +12:00
elementdialog.h
makro
2026-04-26 10:48:47 +02:00
elementprovider.cpp
Replace deprecated qAsConst with std::as_const
2026-07-14 19:27:16 +02:00
elementprovider.h
One year
2026-01-16 15:24:35 +01:00
elementscategoryeditor.cpp
One year
2026-01-16 15:24:35 +01:00
elementscategoryeditor.h
One year
2026-01-16 15:24:35 +01:00
elementscollectioncache.cpp
Wrap deprecated QSqlDatabase::exec() in QSqlQuery
2026-07-14 19:27:17 +02:00
elementscollectioncache.h
One year
2026-01-16 15:24:35 +01:00
elementsmover.cpp
Fix grid and guide startup behavior and update german translation
2026-06-16 17:41:03 +02:00
elementsmover.h
One year
2026-01-16 15:24:35 +01:00
elementspanel.cpp
Fix and Improve Multi-selection for Diagram Operations
2026-05-13 19:42:11 +02:00
elementspanel.h
Fix and Improve Multi-selection for Diagram Operations
2026-05-13 19:42:11 +02:00
elementspanelwidget.cpp
Renew element uuids when duplicating a folio
2026-07-14 19:48:31 +02:00
elementspanelwidget.h
Feat: Add ability to duplicate diagrams/folios with all metadata and elements
2026-05-29 19:14:36 +02:00
elementtextpattern.cpp
One year
2026-01-16 15:24:35 +01:00
elementtextpattern.h
One year
2026-01-16 15:24:35 +01:00
elementtextsmover.cpp
One year
2026-01-16 15:24:35 +01:00
elementtextsmover.h
One year
2026-01-16 15:24:35 +01:00
exportdialog.cpp
Fix four memory leaks found by AddressSanitizer
2026-06-21 01:45:07 +12:00
exportdialog.h
One year
2026-01-16 15:24:35 +01:00
exportproperties.cpp
Address review feedback: double spinboxes, tabs, and fix export bug
2026-06-18 13:37:24 +02:00
exportproperties.h
Address review feedback: double spinboxes, tabs, and fix export bug
2026-06-18 13:37:24 +02:00
exportpropertieswidget.cpp
One year
2026-01-16 15:24:35 +01:00
exportpropertieswidget.h
One year
2026-01-16 15:24:35 +01:00
genericpanel.cpp
Fix four memory leaks found by AddressSanitizer
2026-06-21 01:45:07 +12:00
genericpanel.h
Fix losing Focus on moving diagram position with keyboard
2026-04-19 10:44:52 +02:00
machine_info.cpp
Fix remaining Qt6 build errors after PR #540
2026-07-17 10:25:49 +02:00
machine_info.h
Fix three uninitialised-value bugs found by Valgrind
2026-06-20 22:31:06 +12:00
main.cpp
Fix remaining Qt6 build warnings (narrowing, nodiscard, qHash)
2026-07-14 19:27:37 +02:00
newelementwizard.cpp
One year
2026-01-16 15:24:35 +01:00
newelementwizard.h
One year
2026-01-16 15:24:35 +01:00
pdf_links.cpp
PDF links: extract pdf_links.{cpp,h} shared helper
2026-06-11 23:48:14 +12:00
pdf_links.h
PDF links: extract pdf_links.{cpp,h} shared helper
2026-06-11 23:48:14 +12:00
projectview.cpp
Fix and Improve Multi-selection for Diagram Operations
2026-05-13 19:42:11 +02:00
projectview.h
Fix and Improve Multi-selection for Diagram Operations
2026-05-13 19:42:11 +02:00
qet.cpp
One year
2026-01-16 15:24:35 +01:00
qet.h
One year
2026-01-16 15:24:35 +01:00
qetapp.cpp
Merge pull request #558 from ispyisail/fix/clear-broken-stylesheet
2026-07-26 15:32:11 +02:00
qetapp.h
macOS: fix QFileOpenEvent routing for .qet/.elmt/.titleblock double-click
2026-06-21 12:10:13 +02:00
qetarguments.cpp
One year
2026-01-16 15:24:35 +01:00
qetarguments.h
One year
2026-01-16 15:24:35 +01:00
qetdiagrameditor.cpp
feat: add backup dialog when opening an existing project
2026-07-07 21:42:45 +02:00
qetdiagrameditor.h
Merge pull request #509 from Kellermorph/master
2026-07-07 16:34:56 +02:00
qeticons.cpp
Add Korean switch language
2026-02-02 14:44:10 +01:00
qeticons.h
Add Korean switch language
2026-02-02 14:44:10 +01:00
qetinformation.cpp
Feature: Allow excluding specific elements from BOM (Nomenclature)
2026-05-28 12:23:54 +02:00
qetinformation.h
One year
2026-01-16 15:24:35 +01:00
qetmainwindow.cpp
One year
2026-01-16 15:24:35 +01:00
qetmainwindow.h
One year
2026-01-16 15:24:35 +01:00
qetmessagebox.cpp
One year
2026-01-16 15:24:35 +01:00
qetmessagebox.h
One year
2026-01-16 15:24:35 +01:00
qetproject.cpp
Log project load times, split by phase
2026-07-27 17:37:49 +12:00
qetproject.h
Merge pull request #509 from Kellermorph/master
2026-07-07 16:34:56 +02:00
qetregexpvalidator.cpp
One year
2026-01-16 15:24:35 +01:00
qetregexpvalidator.h
One year
2026-01-16 15:24:35 +01:00
qetresult.cpp
One year
2026-01-16 15:24:35 +01:00
qetresult.h
One year
2026-01-16 15:24:35 +01:00
qetversion.cpp
Revert "Set QET version to 0.200.1 when built with Qt6"
2026-07-19 13:26:34 +02:00
qetversion.h
One year
2026-01-16 15:24:35 +01:00
qetxml.cpp
One year
2026-01-16 15:24:35 +01:00
qetxml.h
Fix remaining Qt6 build errors after PR #540
2026-07-17 10:25:49 +02:00
qfilenameedit.cpp
One year
2026-01-16 15:24:35 +01:00
qfilenameedit.h
One year
2026-01-16 15:24:35 +01:00
qgimanager.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
qgimanager.h
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
qtextorientationspinboxwidget.cpp
One year
2026-01-16 15:24:35 +01:00
qtextorientationspinboxwidget.h
One year
2026-01-16 15:24:35 +01:00
qtextorientationwidget.cpp
One year
2026-01-16 15:24:35 +01:00
qtextorientationwidget.h
One year
2026-01-16 15:24:35 +01:00
recentfiles.cpp
Fix : can't open recent file
2026-07-17 10:29:13 +02:00
recentfiles.h
Fix : can't open recent file
2026-07-17 10:29:13 +02:00
titleblockcell.cpp
Wrap code for better readability
2020-09-07 22:03:40 +02:00
titleblockcell.h
One year
2026-01-16 15:24:35 +01:00
titleblockproperties.cpp
One year
2026-01-16 15:24:35 +01:00
titleblockproperties.h
One year
2026-01-16 15:24:35 +01:00
titleblocktemplate.cpp
Fix the remaining Qt6 compile blockers
2026-07-17 21:01:26 +02:00
titleblocktemplate.h
One year
2026-01-16 15:24:35 +01:00
titleblocktemplaterenderer.cpp
Wrap code for better readability
2020-09-07 22:03:40 +02:00
titleblocktemplaterenderer.h
One year
2026-01-16 15:24:35 +01:00
wiringlistexport.cpp
CLI export: add wiring list and wire-number list (CSV)
2026-06-11 12:39:43 +12:00
wiringlistexport.h
CLI export: add wiring list and wire-number list (CSV)
2026-06-11 12:39:43 +12:00