Dieter Mayer 96f6fa44ad Replace hash.keys().contains(k) with hash.contains(k) (35 call sites) ...

QHash/QMap::keys() allocates a list of every key on each call, then
contains() searches it linearly - an accidental O(n) plus allocation
where a direct O(1) lookup was meant. 35 occurrences across 7 files,
found while profiling project load times (context: #553/#560).

The hot one is ElementPictureFactory::getPictures(), which runs once
per element instance on project load: on the 3399 KiB example project
(191 instances, 129 cache hits) the keys() detour cost 45 ms of the
1.34 s total - measured, not estimated; the fix reproducibly shaves
~35-45 ms off that load. The remaining call sites are UI paths
(search&replace, dynamic text model, undo commands) where the waste
scales with selection/model size.

No behavior change: for QHash/QMap, keys().contains(k) and
contains(k) are equivalent by definition.

(cherry picked from commit 0a7f8f072fa68de7c01a9fc134a4bc8e16d62062)

2026-07-28 13:58:33 +02:00

..

ui

fix(#283): restore center alignment when loading table config

2026-06-21 20:41:25 +12:00

elementfactory.cpp

One year

2026-01-16 15:24:35 +01:00

elementfactory.h

One year

2026-01-16 15:24:35 +01:00

elementpicturefactory.cpp

Replace hash.keys().contains(k) with hash.contains(k) (35 call sites)

2026-07-28 13:58:33 +02:00

elementpicturefactory.h

One year

2026-01-16 15:24:35 +01:00

propertieseditorfactory.cpp

One year

2026-01-16 15:24:35 +01:00

propertieseditorfactory.h

One year

2026-01-16 15:24:35 +01:00

qetgraphicstablefactory.cpp

Fix grid and guide startup behavior and update german translation

2026-06-16 17:41:03 +02:00

qetgraphicstablefactory.h

One year

2026-01-16 15:24:35 +01:00