mirror of
https://github.com/qelectrotech/qelectrotech-source-mirror.git
synced 2026-10-22 14:24:13 +02:00
ispyisail
dc30b26dab
#1533 stopped the panel shrinking to its title bar when the selection had nothing to edit, so that it would keep the height the user gave it (#1439). Users want the room back for the Collections and Auto numbering panels while nothing is selected (#1566). The panel's layout is back to QLayout::SetMaximumSize, so the empty panel shrinks as before. Just before its last editor goes, the panel keeps the heights of every docked panel in its area; when an editor comes back it gives them back with QMainWindow::resizeDocks, the call a separator drag makes. Giving only this panel its height back fell 35 px short in the test: the neighbours had been split again from their size hints and gave up only part of the room. Test: tst_selectionpanelheight now checks, twice over, that the empty panel shrinks and that selecting an element again brings back the height the user gave it. Without the restore the panel comes back at 470 px instead of 560; on master the empty panel does not shrink. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
73 lines
2.3 KiB
C++
73 lines
2.3 KiB
C++
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
#include "qetapptest.h"
|
|
|
|
#include "projectview.h"
|
|
#include "qetgraphicsitem/element.h"
|
|
|
|
#include <QDockWidget>
|
|
|
|
// The Selection properties panel shrinks to its title bar while the selection
|
|
// has nothing it can edit, so the other panels get the room (#1566), and gets
|
|
// back the height the user gave it when an element is selected again. Before
|
|
// #1439 it came back at its default height; #1533 kept the height but no
|
|
// longer shrank.
|
|
class tst_selectionpanelheight : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
QTemporaryDir m_dir;
|
|
|
|
private slots:
|
|
void keepsUserHeight()
|
|
{
|
|
QETDiagramEditor *editor = QetAppTest::editor();
|
|
QVERIFY(editor);
|
|
// Tall enough to leave the panels room to be resized: at a
|
|
// usual height every right-hand panel is at its minimum
|
|
editor->resize(1600, 1500);
|
|
editor->show();
|
|
QVERIFY(QTest::qWaitForWindowExposed(editor));
|
|
|
|
// A copy: opening a project leaves a lock file beside it
|
|
const QString copy = m_dir.filePath("p.qet");
|
|
QVERIFY(QFile::copy(QFINDTESTDATA("fixtures/ten_sequential_numbers.qet"), copy));
|
|
QVERIFY(editor->openAndAddProject(copy, false));
|
|
Diagram *diagram = editor->currentProjectView()->currentDiagram()->diagram();
|
|
Element *element = nullptr;
|
|
for (QGraphicsItem *qgi : diagram->items())
|
|
if (qgi->type() == Element::Type)
|
|
element = static_cast<Element *>(qgi);
|
|
QVERIFY(element);
|
|
|
|
auto panel = editor->findChild<QDockWidget *>("diagram_properties_editor_dock_widget");
|
|
QVERIFY(panel);
|
|
|
|
// The panel follows the selection through a queued connection
|
|
auto select = [&](Element *e) {
|
|
diagram->clearSelection();
|
|
if (e)
|
|
e->setSelected(true);
|
|
QTest::qWait(200);
|
|
};
|
|
|
|
select(element);
|
|
const int start = panel->height();
|
|
// What dragging the separator above the panel does
|
|
editor->resizeDocks({panel}, {start + 150}, Qt::Vertical);
|
|
QTest::qWait(200);
|
|
const int user = panel->height();
|
|
QVERIFY2(user > start, "the panel could not be made taller");
|
|
|
|
for (int round = 0; round < 2; ++round) {
|
|
select(nullptr);
|
|
QVERIFY2(panel->height() < start / 4, "the empty panel did not shrink");
|
|
select(element);
|
|
QCOMPARE(panel->height(), user);
|
|
}
|
|
}
|
|
};
|
|
|
|
QET_APP_TEST_MAIN(tst_selectionpanelheight)
|
|
|
|
#include "tst_selectionpanelheight.moc"
|